Skip to content

Add benchmark action for skywalking#25

Merged
DaGeRe merged 3 commits intokieker-monitoring:mainfrom
Marcel-Ha:support-skywalking
Mar 6, 2025
Merged

Add benchmark action for skywalking#25
DaGeRe merged 3 commits intokieker-monitoring:mainfrom
Marcel-Ha:support-skywalking

Conversation

@Marcel-Ha
Copy link
Contributor

Adds the benchmark action for skywalking. Its an adapted version of the scouter benchmark action.

@DaGeRe
Copy link
Collaborator

DaGeRe commented Mar 6, 2025

Thanks for the PR, was there a reason to set NUM_OF_LOOPS to 3 instead of 10 (how it is configured for the other benchmarks)?

@Marcel-Ha
Copy link
Contributor Author

It is set to 3 in benchmarkScouterJava.yaml. You said I should base it on that, so I thought that was intentionally reduced to 3.

Should I increase it to 10 in both benchmarks?

@DaGeRe
Copy link
Collaborator

DaGeRe commented Mar 6, 2025

Sorry, my bad. The execution frequency, set by the cron configuration, should be lower in all Scouter, Skywalking, Elastic, etc.. We still need NUM_OF_LOOPS=10 for reliable results, would be nice if you could adapt this.

@Marcel-Ha
Copy link
Contributor Author

Done.

@DaGeRe
Copy link
Collaborator

DaGeRe commented Mar 6, 2025

Thanks, look good

@DaGeRe DaGeRe merged commit 6b1233d into kieker-monitoring:main Mar 6, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants