Fixed the InstrumentOnImportFinder instrumentation method#36
Open
shinhyungyang wants to merge 2 commits intokieker-monitoring:mainfrom
Open
Fixed the InstrumentOnImportFinder instrumentation method#36shinhyungyang wants to merge 2 commits intokieker-monitoring:mainfrom
shinhyungyang wants to merge 2 commits intokieker-monitoring:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
tools/pybenchmark, Kieker-python'sInstrumentOnImportFinderinstrumentation method was not working correctly. We can just change the current working directory before launching the benchmark each time.ast_import_hook_newwhich merged all new changes from the master.PostImportFinderinstrumentation method does not seem to be effective. It is okay until Python 3.10 (I checked), but becomes ineffective from Python 3.11, I will keep up with this.