Update data entry validation for csb#54
Merged
jschuurk-kr merged 38 commits intomainfrom Apr 20, 2026
Merged
Conversation
jorisleker
previously approved these changes
Apr 2, 2026
jorisleker
reviewed
Apr 3, 2026
Contributor
jorisleker
left a comment
There was a problem hiding this comment.
Stuk overzichtelijker zo @jschuurk-kr, top!
Paar vooral inhoudelijke comments, deels om ook met Lodewijk te bespreken
praseodym
previously approved these changes
Apr 16, 2026
praseodym
previously approved these changes
Apr 17, 2026
Changed all* validation message title for typists to 'Controleer je antwoorden'. Goal is to make sure validation messages will collapse in cases where it is more likely that one input error triggers multiple validation messages, and reduce the cognitive load for the typist. \* Did not update validation messages for the F.4** range, because they consist of both a title and a specific message.
stacktraceghost
approved these changes
Apr 20, 2026
praseodym
approved these changes
Apr 20, 2026
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Do also check the commit messages for a list of the changes.
TODO
Questions for draft PR ✔️
=> table
=> frontend can check committee category and counting method to determine which text to show for a particilar error code
Questions for review
=> We also add a warning when eligible voters is lower than stempassen.