Skip to content

Update data entry validation for csb#54

Merged
jschuurk-kr merged 38 commits intomainfrom
update-data-entry-validation-rules-for-csb
Apr 20, 2026
Merged

Update data entry validation for csb#54
jschuurk-kr merged 38 commits intomainfrom
update-data-entry-validation-rules-for-csb

Conversation

@jschuurk-kr
Copy link
Copy Markdown
Contributor

@jschuurk-kr jschuurk-kr commented Apr 1, 2026

Scope

  • merge CSO and DSO rules that check the same things
  • F.310 also applies for DSO
  • change error code for F.360 to be consecutive with the other F.3xx errors
  • add rule to check if E is empty or 0 when it should not be
  • add rules voor CSB
  • check handelingsperspectieven CSO and DSO, esp. for "rubriek 3.3"

Do also check the commit messages for a list of the changes.

TODO

Questions for draft PR ✔️

  1. Can I proceed with the change to the version that has the table? Or do you have a better idea how to distinguish rules and texts for GSB CSO, GSB DSO, CSB (and later HSB)?
    => table
  2. For GSB CSO and CSB CSO we have in some cases the same checks, but different texts for the coordinator. What is a convenient way to handle that in the frontend? Can we just check for committee category? Or should the difference be part of the error/warning code?
    => frontend can check committee category and counting method to determine which text to show for a particilar error code

Questions for review

  1. Is it correct that the rules in "Regels voor extra onderzoek en controles (reeks F.1xx)" only apply to first sessions? Since they refer to fields only available on the PVs of the first session, which are not part of data entry for any later session. => @lode-coder suggests it is not applicable.
  2. For the rule of number of eligible voters, I added a check if it's empty or 0. We also discussed checking if it's larger than number of 'stempassen' + 'volmachtsbewijzen'. That's a valid but also somewhat arbitrary lower bound, though. So I think we should rely on the double data entry for the number to be correct.
    => We also add a warning when eligible voters is lower than stempassen.

jorisleker
jorisleker previously approved these changes Apr 2, 2026
@jschuurk-kr jschuurk-kr marked this pull request as ready for review April 2, 2026 12:59
Copy link
Copy Markdown
Contributor

@jorisleker jorisleker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuk overzichtelijker zo @jschuurk-kr, top!

Paar vooral inhoudelijke comments, deels om ook met Lodewijk te bespreken

Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
Comment thread use-cases/validatieregels-plausibiliteitschecks-tellingen.md Outdated
praseodym
praseodym previously approved these changes Apr 16, 2026
praseodym
praseodym previously approved these changes Apr 17, 2026
Changed all* validation message title for typists to 'Controleer je antwoorden'. Goal is to make sure validation messages will collapse in cases where it is more likely that one input error triggers multiple validation messages, and reduce the cognitive load for the typist. 

\* Did not update validation messages for the F.4** range, because they consist of both a title and a specific message.
@jschuurk-kr jschuurk-kr merged commit 808d3f1 into main Apr 20, 2026
1 check passed
@jschuurk-kr jschuurk-kr deleted the update-data-entry-validation-rules-for-csb branch April 20, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants