Skip to content

Add tests and run before build#1

Merged
chrismostert merged 3 commits into
mainfrom
add-tests
Jan 23, 2026
Merged

Add tests and run before build#1
chrismostert merged 3 commits into
mainfrom
add-tests

Conversation

@oliver3

@oliver3 oliver3 commented Jan 22, 2026

Copy link
Copy Markdown
Contributor
  • Added pytest tests, we did not see a need to use a separate library for snapshot creation and file comparison
  • Add test step for GitHub builds

Coverage after adding tests:

Name                      Stmts   Miss Branch BrPart  Cover
-----------------------------------------------------------
src/eml2csv/__init__.py       2      0      0      0   100%
src/eml2csv/lib.py          163      7     38      6    94%
src/eml2csv/main.py           7      7      0      0     0%
src/eml2csv/util.py          31      8     10      4    66%
tests/__init__.py             0      0      0      0   100%
tests/test_eml2csv.py        45      0      0      0   100%
-----------------------------------------------------------
TOTAL                       248     22     48     10    89%

Co-authored-by: Joep Schuurkes <145749778+jschuurk-kr@users.noreply.github.com>

@chrismostert chrismostert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks. Tests look good.

I've added a separate github workflow which runs on commits since the existing workflow only runs when we create a release to add the binaries to that release. This ensures that we also run the test suite on individual commits

@chrismostert chrismostert merged commit 150de27 into main Jan 23, 2026
1 check passed
@chrismostert chrismostert deleted the add-tests branch January 23, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants