Open
Conversation
Simple Account refactor without breaking initial tests, Update Libraries
Add account Transfer and refactor Transaction, Add Balance to account to avoid constant recalc. add Transfer and Transaction tests without breaking existing tests
Refactor Bank and add Coverage Tests
Added Functionalitiy for Maxi Savings after Withdral in past 10 days. Refactored TransactionType and AccountStatementType to Enums. Build new tests for multi accounts and new functionality.
Notes: Based on the original code, this is calculating future one year interest based on the rules and rates given. It does not compound interest, add interest into the balance or actually compound on a daily basis. If these are required features, they can be added simply but it seemed like that was not the intent of a two hour refactoring.
Added daily, accrual, ability to add transactions in the past and accrue daily to current date. Added MaxSavingAccountAdj, with .05 interest, with a 10 day adjustment to .001 on withdraw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features Added, Now does Daily Accrual, and Adjustable Rate MaxiSavings
Added daily, accrual, ability to add transactions in the past and accrue daily to current date.
Added MaxiSavingAccountAdj, with .05 interest, with a 10 day adjustment to .001 on withdraw.
Left the Original MaxiSavingsAccount with the three bounded rates
Notes: First Based on the original code, this was calculating future one year interest based on the rules and rates given.
It did not compound interest, add interest into the balance or actually compound on a daily basis. If these are required features, they can be added simply.