Allow sidemenu content to be disabled #467
Open
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first pr to an open source project. I love this library, however I would like to change the way the sidemenu works. How it currently works seems to be with a splitview, with the side menu on the left and main content on the right. I do not want the main content, because I render my views a different way, so the default was causing unintended issues. I have made a change to the project, which allows for the main content section to be hidden when setting the IsContentVisible in the sidemenu to False. I have set the default to True so that it is an opt in functionality and wont affect existing codebase functionality.
Without IsContentVisible:
Because I was not using the default pagecontent it would render out the binding. Setting IsContentVisible=False, fixes this issue.
Thanks.