Skip to content

feat(LAB-4081): aau i can use the is not operator on status step assignee #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+182 −74
Open

feat(LAB-4081): aau i can use the is not operator on status step assignee #1987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e9566c
feat(LAB-4081): add "is not" operator filters to Python SDK for statu…
paulruelle Nov 19, 2025
c623921
test(LAB-4081): add unit tests for "is not" operator filters in asset…
paulruelle Nov 19, 2025
69b58df
fix(LAB-4081): fix pylint/pyright
paulruelle Nov 20, 2025
211507c
fix(LAB-4081): remove `status_not_in` filter on workflow V1 legacy pr…
paulruelle Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/kili/adapters/kili_api_gateway/asset/mappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,7 @@ def asset_where_mapper(filters: AssetFilters):
"status": filters.issue_status,
},
"stepIdIn": filters.step_id_in,
"stepIdNotIn": filters.step_id_not_in,
"stepStatusIn": filters.step_status_in,
"stepStatusNotIn": filters.step_status_not_in,
}
6 changes: 5 additions & 1 deletion src/kili/domain/asset/asset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,20 @@ class AssetFilters:
skipped: Optional[bool] = None
status_in: Optional[ListOrTuple[AssetStatus]] = None
step_id_in: Optional[ListOrTuple[str]] = None
step_id_not_in: Optional[ListOrTuple[str]] = None
step_status_in: Optional[ListOrTuple[StatusInStep]] = None
step_status_not_in: Optional[ListOrTuple[StatusInStep]] = None


class AssetWorkflowFilters(TypedDict):
class AssetWorkflowFilters(TypedDict, total=False):
"""Asset filters relative to worklow."""

skipped: Optional[bool]
status_in: Optional[ListOrTuple[AssetStatus]]
step_name_in: Optional[ListOrTuple[str]]
step_name_not_in: Optional[ListOrTuple[str]]
step_status_in: Optional[ListOrTuple[StatusInStep]]
step_status_not_in: Optional[ListOrTuple[StatusInStep]]


def get_asset_default_fields(
Expand Down
2 changes: 2 additions & 0 deletions src/kili/domain_api/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ class AssetFilter(TypedDict, total=False):
skipped: Optional[bool]
status_in: Optional[list[AssetStatus]]
step_name_in: Optional[list[str]]
step_name_not_in: Optional[list[str]]
step_status_in: Optional[list[StatusInStep]]
step_status_not_in: Optional[list[StatusInStep]]
updated_at_gte: Optional[str]
updated_at_lte: Optional[str]

Expand Down
195 changes: 122 additions & 73 deletions src/kili/presentation/client/asset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,55 @@
import pandas as pd


def _warn_deprecated_gt_lt_args(
consensus_mark_gt: Optional[float],
consensus_mark_lt: Optional[float],
honeypot_mark_gt: Optional[float],
honeypot_mark_lt: Optional[float],
label_consensus_mark_gt: Optional[float],
label_consensus_mark_lt: Optional[float],
label_created_at_gt: Optional[str],
label_created_at_lt: Optional[str],
label_honeypot_mark_gt: Optional[float],
label_honeypot_mark_lt: Optional[float],
) -> None:
"""Warn about deprecated _gt and _lt arguments."""
for arg_name, arg_value in zip(
(
"consensus_mark_gt",
"consensus_mark_lt",
"honeypot_mark_gt",
"honeypot_mark_lt",
"label_consensus_mark_gt",
"label_consensus_mark_lt",
"label_created_at_gt",
"label_created_at_lt",
"label_honeypot_mark_gt",
"label_honeypot_mark_lt",
),
(
consensus_mark_gt,
consensus_mark_lt,
honeypot_mark_gt,
honeypot_mark_lt,
label_consensus_mark_gt,
label_consensus_mark_lt,
label_created_at_gt,
label_created_at_lt,
label_honeypot_mark_gt,
label_honeypot_mark_lt,
),
strict=False,
):
if arg_value:
warnings.warn(
f"'{arg_name}' is deprecated, please use"
f" '{arg_name.replace('_gt', '_gte').replace('_lt', '_lte')}' instead.",
DeprecationWarning,
stacklevel=2,
)


@for_all_methods(log_call, exclude=["__init__"])
class AssetClientMethods(BaseClientMethods):
"""Methods attached to the Kili client, to run actions on assets."""
Expand Down Expand Up @@ -108,7 +157,9 @@ def assets(
skipped: Optional[bool] = None,
status_in: Optional[list[AssetStatus]] = None,
step_name_in: Optional[list[str]] = None,
step_name_not_in: Optional[list[str]] = None,
step_status_in: Optional[list[StatusInStep]] = None,
step_status_not_in: Optional[list[StatusInStep]] = None,
*,
as_generator: Literal[True],
) -> Generator[dict, None, None]:
Expand Down Expand Up @@ -174,7 +225,9 @@ def assets(
skipped: Optional[bool] = None,
status_in: Optional[list[AssetStatus]] = None,
step_name_in: Optional[list[str]] = None,
step_name_not_in: Optional[list[str]] = None,
step_status_in: Optional[list[StatusInStep]] = None,
step_status_not_in: Optional[list[StatusInStep]] = None,
*,
as_generator: Literal[False] = False,
) -> list[dict]:
Expand Down Expand Up @@ -240,7 +293,9 @@ def assets(
skipped: Optional[bool] = None,
status_in: Optional[list[AssetStatus]] = None,
step_name_in: Optional[list[str]] = None,
step_name_not_in: Optional[list[str]] = None,
step_status_in: Optional[list[StatusInStep]] = None,
step_status_not_in: Optional[list[StatusInStep]] = None,
*,
as_generator: bool = False,
) -> Union[Iterable[dict], "pd.DataFrame"]:
Expand Down Expand Up @@ -312,8 +367,13 @@ def assets(
Only applicable if the project is in the WorkflowV1 (legacy).
step_name_in: Returned assets are in the step whose name belong to that list, if given.
Only applicable if the project is in WorkflowV2.
step_name_not_in: Returned assets are in the step whose name does not belong to that list, if given.
Only applicable if the project is in WorkflowV2.
step_status_in: Returned assets have the status in their step that belongs to that list, if given.
Only applicable if the project is in WorkflowV2.
step_status_not_in: Returned assets have the status in their step that does not belong to that list, if given.
Possible choices: `TO_DO`, `DOING`, `PARTIALLY_DONE`, `REDO`, `DONE`, `SKIPPED`.
Only applicable if the project is in WorkflowV2.

!!! info "Dates format"
Date strings should have format: "YYYY-MM-DD"
Expand Down Expand Up @@ -374,40 +434,18 @@ def assets(
stacklevel=1,
)

for arg_name, arg_value in zip(
(
"consensus_mark_gt",
"consensus_mark_lt",
"honeypot_mark_gt",
"honeypot_mark_lt",
"label_consensus_mark_gt",
"label_consensus_mark_lt",
"label_created_at_gt",
"label_created_at_lt",
"label_honeypot_mark_gt",
"label_honeypot_mark_lt",
),
(
consensus_mark_gt,
consensus_mark_lt,
honeypot_mark_gt,
honeypot_mark_lt,
label_consensus_mark_gt,
label_consensus_mark_lt,
label_created_at_gt,
label_created_at_lt,
label_honeypot_mark_gt,
label_honeypot_mark_lt,
),
strict=False,
):
if arg_value:
warnings.warn(
f"'{arg_name}' is deprecated, please use"
f" '{arg_name.replace('_gt', '_gte').replace('_lt', '_lte')}' instead.",
DeprecationWarning,
stacklevel=1,
)
_warn_deprecated_gt_lt_args(
consensus_mark_gt=consensus_mark_gt,
consensus_mark_lt=consensus_mark_lt,
honeypot_mark_gt=honeypot_mark_gt,
honeypot_mark_lt=honeypot_mark_lt,
label_consensus_mark_gt=label_consensus_mark_gt,
label_consensus_mark_lt=label_consensus_mark_lt,
label_created_at_gt=label_created_at_gt,
label_created_at_lt=label_created_at_lt,
label_honeypot_mark_gt=label_honeypot_mark_gt,
label_honeypot_mark_lt=label_honeypot_mark_lt,
)

disable_tqdm = disable_tqdm_if_as_generator(as_generator, disable_tqdm)

Expand All @@ -430,26 +468,36 @@ def assets(
)

step_id_in = None
if (
step_name_in is not None
or step_status_in is not None
step_id_not_in = None
has_step_filters = step_name_in is not None or step_name_not_in is not None
has_status_filters = (
step_status_in is not None
or step_status_not_in is not None
or status_in is not None
or skipped is not None
):
)
if has_step_filters or has_status_filters:
check_asset_workflow_arguments(
project_workflow_version=project_workflow_version,
asset_workflow_filters={
"skipped": skipped,
"status_in": status_in,
"step_name_in": step_name_in,
"step_name_not_in": step_name_not_in,
"step_status_in": step_status_in,
"step_status_not_in": step_status_not_in,
},
)
if project_workflow_version == "V2" and step_name_in is not None:
step_id_in = extract_step_ids_from_project_steps(
project_steps=project_steps,
step_name_in=step_name_in,
)
if project_workflow_version == "V2" and step_name_not_in is not None:
step_id_not_in = extract_step_ids_from_project_steps(
project_steps=project_steps,
step_name_in=step_name_not_in,
)

asset_use_cases = AssetUseCases(self.kili_api_gateway)
filters = AssetFilters(
Expand Down Expand Up @@ -495,7 +543,9 @@ def assets(
issue_status=issue_status,
issue_type=issue_type,
step_id_in=step_id_in,
step_id_not_in=step_id_not_in,
step_status_in=step_status_in,
step_status_not_in=step_status_not_in,
)
assets_gen = asset_use_cases.list_assets(
filters,
Expand Down Expand Up @@ -568,7 +618,9 @@ def count_assets(
external_id_strictly_in: Optional[list[str]] = None,
external_id_in: Optional[list[str]] = None,
step_name_in: Optional[list[str]] = None,
step_name_not_in: Optional[list[str]] = None,
step_status_in: Optional[list[StatusInStep]] = None,
step_status_not_in: Optional[list[StatusInStep]] = None,
) -> int:
# pylint: disable=line-too-long
"""Count and return the number of assets with the given constraints.
Expand Down Expand Up @@ -627,9 +679,14 @@ def count_assets(
For example, with `external_id_in=['abc']`, any asset with an external id containing `'abc'` will be returned.
step_name_in: Returned assets are in a step whose name belong to that list, if given.
Only applicable if the project is in WorkflowV2.
step_name_not_in: Returned assets are in a step whose name does not belong to that list, if given.
Only applicable if the project is in WorkflowV2.
step_status_in: Returned assets have the status of their step that belongs to that list, if given.
Possible choices: `TO_DO`, `DOING`, `PARTIALLY_DONE`, `REDO`, `DONE`, `SKIPPED`.
Only applicable if the project is in WorkflowV2.
step_status_not_in: Returned assets have the status of their step that does not belong to that list, if given.
Possible choices: `TO_DO`, `DOING`, `PARTIALLY_DONE`, `REDO`, `DONE`, `SKIPPED`.
Only applicable if the project is in WorkflowV2.

!!! info "Dates format"
Date strings should have format: "YYYY-MM-DD"
Expand Down Expand Up @@ -658,43 +715,26 @@ def count_assets(
stacklevel=1,
)

for arg_name, arg_value in zip(
(
"consensus_mark_gt",
"consensus_mark_lt",
"honeypot_mark_gt",
"honeypot_mark_lt",
"label_consensus_mark_gt",
"label_consensus_mark_lt",
"label_created_at_gt",
"label_created_at_lt",
"label_honeypot_mark_gt",
"label_honeypot_mark_lt",
),
(
consensus_mark_gt,
consensus_mark_lt,
honeypot_mark_gt,
honeypot_mark_lt,
label_consensus_mark_gt,
label_consensus_mark_lt,
label_created_at_gt,
label_created_at_lt,
label_honeypot_mark_gt,
label_honeypot_mark_lt,
),
strict=False,
):
if arg_value:
warnings.warn(
f"'{arg_name}' is deprecated, please use"
f" '{arg_name.replace('_gt', '_gte').replace('_lt', '_lte')}' instead.",
DeprecationWarning,
stacklevel=1,
)
_warn_deprecated_gt_lt_args(
consensus_mark_gt=consensus_mark_gt,
consensus_mark_lt=consensus_mark_lt,
honeypot_mark_gt=honeypot_mark_gt,
honeypot_mark_lt=honeypot_mark_lt,
label_consensus_mark_gt=label_consensus_mark_gt,
label_consensus_mark_lt=label_consensus_mark_lt,
label_created_at_gt=label_created_at_gt,
label_created_at_lt=label_created_at_lt,
label_honeypot_mark_gt=label_honeypot_mark_gt,
label_honeypot_mark_lt=label_honeypot_mark_lt,
)

step_id_in = None
if status_in is not None or step_name_in is not None or step_status_in is not None:
step_id_not_in = None
has_step_filters = step_name_in is not None or step_name_not_in is not None
has_status_filters = (
status_in is not None or step_status_in is not None or step_status_not_in is not None
)
if has_step_filters or has_status_filters:
project_use_cases = ProjectUseCases(self.kili_api_gateway)
(
project_steps,
Expand All @@ -705,7 +745,9 @@ def count_assets(
asset_workflow_filters={
"skipped": skipped,
"step_name_in": step_name_in,
"step_name_not_in": step_name_not_in,
"step_status_in": step_status_in,
"step_status_not_in": step_status_not_in,
"status_in": status_in,
},
)
Expand All @@ -715,6 +757,11 @@ def count_assets(
project_steps=project_steps,
step_name_in=step_name_in,
)
if project_workflow_version == "V2" and step_name_not_in is not None:
step_id_not_in = extract_step_ids_from_project_steps(
project_steps=project_steps,
step_name_in=step_name_not_in,
)

filters = AssetFilters(
project_id=ProjectId(project_id),
Expand Down Expand Up @@ -759,7 +806,9 @@ def count_assets(
issue_status=issue_status,
issue_type=issue_type,
step_id_in=step_id_in,
step_id_not_in=step_id_not_in,
step_status_in=step_status_in,
step_status_not_in=step_status_not_in,
)
asset_use_cases = AssetUseCases(self.kili_api_gateway)
return asset_use_cases.count_assets(filters)
Loading