Fix free calls #44
Merged
Fix free calls #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Could I trouble you to do a Hackage release with this fix? |
|
Version 0.6.5.1 was uploaded to Hackage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that this library was crashing on Windows due to using the incorrect
freewhen I called thegetfunction.As the LevelDB header file says (see here), it's important to free the memory returned from LevelDB using the same allocator that produced it. For this reason, LevelDB provides the C
leveldb_freefunction.I don't think this causes problems on Linux (although maybe there are subtle security implications?). But the
freefrom Foreign.Alloc.Marshal in Haskell on Windows must use a different allocator because I always get an immediate crash.