-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kinde domain can de defined with or without the https:// #66
Conversation
WalkthroughThe changes add a conditional check in the configuration module to ensure the domain value always includes the "https://" prefix. A new variable is created to hold either the environment value or the provided configuration value. If the domain is missing the prefix, it is prepended with "https://". The resulting domain value is then used when setting the audience and kindeDomain properties in the merge routine. Error handling for missing domain values remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant U as Config Loader
participant C as Configuration Module
participant M as Merge Function
U->>C: Request configuration
C->>C: Retrieve domain (env or config)
alt Domain missing "https://"
C->>C: Prepend "https://"
end
C->>M: Pass domain to merge routine
M->>M: Set audience and kindeDomain using updated domain
M-->>C: Return merged configuration
C-->>U: Provide complete configuration
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Explain your changes
Documentation suggests to supply the domain without the https://, this PR allows the domain to be supplied with or without the https
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.