Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kinde domain can de defined with or without the https:// #66

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

DanielRivers
Copy link
Contributor

Explain your changes

Documentation suggests to supply the domain without the https://, this PR allows the domain to be supplied with or without the https

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

Copy link
Contributor

coderabbitai bot commented Feb 8, 2025

Walkthrough

The changes add a conditional check in the configuration module to ensure the domain value always includes the "https://" prefix. A new variable is created to hold either the environment value or the provided configuration value. If the domain is missing the prefix, it is prepended with "https://". The resulting domain value is then used when setting the audience and kindeDomain properties in the merge routine. Error handling for missing domain values remains unchanged.

Changes

File(s) Change Summary
lib/config.ts Added logic to determine the domain from the environment variable or provided config; checks if the domain includes "https://" and prepends it if missing; updates the usage of the domain for setting audience and kindeDomain; retains existing error handling for missing domain values.

Sequence Diagram(s)

sequenceDiagram
    participant U as Config Loader
    participant C as Configuration Module
    participant M as Merge Function

    U->>C: Request configuration
    C->>C: Retrieve domain (env or config)
    alt Domain missing "https://"
        C->>C: Prepend "https://"
    end
    C->>M: Pass domain to merge routine
    M->>M: Set audience and kindeDomain using updated domain
    M-->>C: Return merged configuration
    C-->>U: Provide complete configuration
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80402b4 and bf663eb.

📒 Files selected for processing (1)
  • lib/config.ts (1 hunks)
🔇 Additional comments (2)
lib/config.ts (2)

59-60: LGTM! The configuration is correctly updated.

The audience and kindeDomain are consistently set using the prefixed domain value, ensuring proper URL formatting throughout the configuration.


48-52: 🏁 Script executed:

#!/bin/bash
# Create a test file to verify domain handling
cat << 'EOF' > test.ts
import { init } from './lib/config';

// Test cases
console.log('Test 1: Domain without https://');
init({ kindeDomain: 'example.com' });

console.log('\nTest 2: Domain with https://');
init({ kindeDomain: 'https://example.com' });

console.log('\nTest 3: Domain from environment without https://');
process.env.KINDE_DOMAIN = 'example.com';
init();

console.log('\nTest 4: Domain from environment with https://');
process.env.KINDE_DOMAIN = 'https://example.com';
init();
EOF

# Run the TypeScript file
ts-node test.ts

Length of output: 122

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DanielRivers DanielRivers merged commit 24d2dec into main Feb 20, 2025
2 of 3 checks passed
@DanielRivers DanielRivers deleted the feat/flexible-kinde-domain-definition branch February 20, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant