Add plt build command to download and cut playlist media by statik · Pull Request #887 · kindlyops/vbs

statik · 2026-06-11T18:42:08Z

Summary

Second phase of the plt command group. Adds vbs plt build <playlist>,
which turns a purple playlist into a self-contained, play-ready working
directory.

Stacked on #886 (Phase 1). Review/merge that first; this targets
plt-phase-1 and will retarget main once #886 merges.

The pipeline:

Resolve each catalog location to a media-API query (pub/track, book/chapter,
docid shapes) and pick a rendition (default 720p, --resolution; falls
back to the highest available with a warning).
Download to a shared cache (UserCacheDir/vbs/media/) with MD5 + size
verification and a JSON sidecar; one re-download on mismatch, then a hard
error. Distinct locations are fetched once.
Cut segment clips by merging markers into contiguous ranges (0.5 s gap),
snapping the start back to the nearest keyframe, and stream-copying (no
re-encode). Non-contiguous markers become lettered sub-clips. Untrimmed,
marker-free videos are copied whole; image cues are extracted from the zip.
Describe with playlist.json (the Phase 3 contract: per-cue markers,
cut metadata, lead-in, raw end action) and a Typst cuesheet.typ, compiled
to cuesheet.pdf when typst is on PATH.

The media endpoint is config-only (plt.mediaapi, overridable with
--media-api) and the build fails fast with an actionable message when unset.
ffmpeg/ffprobe are required and checked up front. New code is standard
library only (no new vendored dependencies).

Test Plan

go test ./cmd/ green: URL builder (3 shapes + unsupported), httptest
client + rendition fallback, cache reuse + checksum/size mismatch,
marker merge (mutation-verified), keyframe probe + ffmpeg cut, image
extraction, cue-sheet render + playlist.json round-trip
Hermetic end-to-end build test (fake media server + generated video):
download→verify→cache, whole-video copy, lettered segment sub-clips, image
extract, playlist.json + cuesheet.typ, cache-hit re-run
bazel build //cmd:go_default_library and bazel test //cmd:go_default_test green
gofmt, go vet, go build ./..., go mod verify, vendor guard clean
funlen / gocyclo / lll within limits
Real build of the example export: 15 cues, media deduped to 10
files, every segment clip snaps to a keyframe within one GOP (lead-ins
0.07–1.75 s), checksum confirmed MD5, re-run completes in ~1.7 s (cache)

statik

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
string sjj has 6 occurrences, make it a constant (goconst)

vbs/cmd/plt_client_test.go

Line 68 in 934af7f

    
           resp, err := fetchMedia(srv.Client(), srv.URL, "ASL", &Location{KeySymbol: "sjj", Track: 135})

🚫 [golangci] _{reported by reviewdog 🐶}
string 720p has 7 occurrences, make it a constant (goconst)

vbs/cmd/plt_client_test.go

Line 106 in 934af7f

if item.Label != "720p" || item.FrameHeight != 720 {

🚫 [golangci] _{reported by reviewdog 🐶}
string meeting Dec 2nd has 3 occurrences, make it a constant (goconst)

vbs/cmd/plt_cuesheet_test.go

Line 27 in 934af7f

Name: "meeting Dec 2nd",

🚫 [golangci] _{reported by reviewdog 🐶}
string meeting-dec-2nd has 3 occurrences, make it a constant (goconst)

vbs/cmd/plt_cuesheet_test.go

Line 28 in 934af7f

Slug: "meeting-dec-2nd",

🚫 [golangci] _{reported by reviewdog 🐶}
string ASL has 7 occurrences, make it a constant (goconst)

vbs/cmd/plt_cuesheet_test.go

Line 29 in 934af7f

Language: langInfo{ID: 420, Code: "ASL"},

🚫 [golangci] _{reported by reviewdog 🐶}
string grapes.jpg has 3 occurrences, make it a constant (goconst)

vbs/cmd/plt_cuesheet_test.go

Line 50 in 934af7f

Index: 3, Label: "grapes.jpg", Kind: "image",

🚫 [golangci] _{reported by reviewdog 🐶}
string nwt has 4 occurrences, make it a constant (goconst)

vbs/cmd/plt_media.go

Line 234 in 934af7f

case loc.KeySymbol == "nwt" && loc.BookNumber > 0:

🚫 [golangci] _{reported by reviewdog 🐶}
string sjj has 6 occurrences, make it a constant (goconst)

vbs/cmd/plt_media_test.go

Line 33 in 934af7f

loc: Location{KeySymbol: "sjj", Track: 135, Type: 0},

🚫 [golangci] _{reported by reviewdog 🐶}
string booknum has 3 occurrences, make it a constant (goconst)

vbs/cmd/plt_media_test.go

Line 35 in 934af7f

forbidden: []string{"booknum", "docid"},

🚫 [golangci] _{reported by reviewdog 🐶}
string nwt has 4 occurrences, make it a constant (goconst)

vbs/cmd/plt_media_test.go

Line 39 in 934af7f

loc: Location{KeySymbol: "nwt", BookNumber: 23, ChapterNumber: 5, Type: 0},

🚫 [golangci] _{reported by reviewdog 🐶}
exitAfterDefer: log.Fatal will exit, and defer func(){...}(...) will not run (gocritic)

vbs/cmd/plt_build.go

Line 85 in 934af7f

log.Fatal().Err(err).Msg("Could not parse playlist")

🚫 [golangci] _{reported by reviewdog 🐶}
unnamedResult: consider giving a name to these results (gocritic)

vbs/cmd/plt_build_integration_test.go

Line 29 in 934af7f

    
           func buildMediaFixtureServer(t *testing.T, video []byte) (*httptest.Server, *int32) {

🚫 [golangci] _{reported by reviewdog 🐶}
rangeValCopy: each iteration copies 136 bytes (consider pointers or indexing) (gocritic)

vbs/cmd/plt_build_integration_test.go

Line 120 in 934af7f

for _, c := range manifest.Cues {

🚫 [golangci] _{reported by reviewdog 🐶}
unnamedResult: consider giving a name to these results (gocritic)

vbs/cmd/plt_cache_test.go

Line 33 in 934af7f

func mediaFileServer(t *testing.T, body []byte) (*httptest.Server, *int32) {

🚫 [golangci] _{reported by reviewdog 🐶}
rangeValCopy: each iteration copies 136 bytes (consider pointers or indexing) (gocritic)

vbs/cmd/plt_cuesheet.go

Line 98 in 934af7f

for _, c := range manifest.Cues {

🚫 [golangci] _{reported by reviewdog 🐶}
rangeValCopy: each iteration copies 136 bytes (consider pointers or indexing) (gocritic)

vbs/cmd/plt_cuesheet.go

Line 114 in 934af7f

for _, c := range manifest.Cues {

🚫 [golangci] _{reported by reviewdog 🐶}
importShadow: shadow of imported package 'url' (gocritic)

vbs/cmd/plt_media.go

Line 164 in 934af7f

    
           func downloadAndVerify(client *http.Client, url, dest string, wantSize int64, wantChecksum string) error {

🚫 [golangci] _{reported by reviewdog 🐶}
G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

vbs/cmd/plt_clips.go

Line 129 in 934af7f

cmd := exec.Command("ffmpeg", "-loglevel", "error",

🚫 [golangci] _{reported by reviewdog 🐶}
G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

vbs/cmd/plt_clips_integration_test.go

Line 42 in 934af7f

cmd := exec.Command("ffmpeg", "-loglevel", "error", "-f", "lavfi",

🚫 [golangci] _{reported by reviewdog 🐶}
G110: Potential DoS vulnerability via decompression bomb (gosec)

vbs/cmd/plt_parse.go

Line 157 in 934af7f

if _, err := io.Copy(out, rc); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o755, in detected (mnd)

vbs/cmd/plt_build.go

Line 159 in 934af7f

if err := os.MkdirAll(filepath.Join(outDir, sub), 0o755); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 5, in detected (mnd)

vbs/cmd/plt_clips.go

Line 90 in 934af7f

from := startSec - 5

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0.1, in detected (mnd)

vbs/cmd/plt_clips.go

Line 94 in 934af7f

interval := fmt.Sprintf("%.3f%%%.3f", from, startSec+0.1)

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 2, in detected (mnd)

vbs/cmd/plt_clips.go

Line 106 in 934af7f

if len(fields) < 2 {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 77 in 934af7f

if err := os.WriteFile(path, append(data, '\n'), 0o600); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 60, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 88 in 934af7f

minutes := int(seconds) / 60

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 60, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 89 in 934af7f

rem := seconds - float64(minutes*60)

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 146 in 934af7f

    
           if err := os.WriteFile(typPath, []byte(renderCueSheet(manifest)), 0o600); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o755, in detected (mnd)

vbs/cmd/plt_media.go

Line 120 in 934af7f

if err := os.MkdirAll(cacheDir, 0o755); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

vbs/cmd/plt_media.go

Line 214 in 934af7f

if err := os.WriteFile(dest+".json", data, 0o600); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
continue with no blank line before (nlreturn)

vbs/cmd/plt_clips.go

Line 64 in 934af7f

continue

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel (paralleltest)

vbs/cmd/plt_cache_test.go

Line 45 in 934af7f

func TestDownloadAndVerify(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_cache_test.go

Line 50 in 934af7f

t.Run("good size and checksum", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_cache_test.go

Line 57 in 934af7f

t.Run("checksum mismatch is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_cache_test.go

Line 64 in 934af7f

t.Run("size mismatch is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFetchToCache_ReusesCache missing the call to method parallel (paralleltest)

vbs/cmd/plt_cache_test.go

Line 72 in 934af7f

func TestFetchToCache_ReusesCache(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFetchMedia_ParsesRenditions missing the call to method parallel (paralleltest)

vbs/cmd/plt_client_test.go

Line 65 in 934af7f

func TestFetchMedia_ParsesRenditions(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel (paralleltest)

vbs/cmd/plt_client_test.go

Line 78 in 934af7f

func TestSelectRendition(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 85 in 934af7f

t.Run("exact 720p", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 98 in 934af7f

t.Run("absent resolution falls back to highest", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 111 in 934af7f

t.Run("missing language is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestProbeKeyframeBefore_Integration missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 65 in 934af7f

func TestProbeKeyframeBefore_Integration(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestCutVerseClip_Integration missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 81 in 934af7f

func TestCutVerseClip_Integration(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestArchiveExtractEntry missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 109 in 934af7f

func TestArchiveExtractEntry(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMergeMarkers missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_test.go

Line 30 in 934af7f

func TestMergeMarkers(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Range statement for test TestMergeMarkers missing the call to method parallel in test Run (paralleltest)

vbs/cmd/plt_clips_test.go

Line 79 in 934af7f

for _, tc := range cases {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFormatTimecode missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 57 in 934af7f

func TestFormatTimecode(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestWritePlaylistJSON_RoundTrips missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 72 in 934af7f

func TestWritePlaylistJSON_RoundTrips(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestRenderCueSheet missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 100 in 934af7f

func TestRenderCueSheet(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildMediaURL missing the call to method parallel (paralleltest)

vbs/cmd/plt_media_test.go

Line 22 in 934af7f

func TestBuildMediaURL(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Range statement for test TestBuildMediaURL missing the call to method parallel in test Run (paralleltest)

vbs/cmd/plt_media_test.go

Line 54 in 934af7f

for _, tc := range cases {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildMediaURL_UnsupportedShape missing the call to method parallel (paralleltest)

vbs/cmd/plt_media_test.go

Line 79 in 934af7f

func TestBuildMediaURL_UnsupportedShape(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 41 in 934af7f

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 51 in 934af7f

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 71 in 934af7f

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 201 in 934af7f

rm, err := ctx.resolveMedia(item.Location)

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 240 in 934af7f

item Item, index int, slug string, rm resolvedMedia, sourceRel, thumb string,

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'r' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 270 in 934af7f

for i, r := range ranges {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 334 in 934af7f

func (ctx *buildContext) ensureMediaCopy(rm resolvedMedia) (string, error) {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'w' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build_integration_test.go

Line 41 in 934af7f

mux.HandleFunc("/", func(w http.ResponseWriter, _ *http.Request) {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'in' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_clips.go

Line 148 in 934af7f

in, err := os.Open(src)

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 95 in 934af7f

var b strings.Builder

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'q' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_media_test.go

Line 64 in 934af7f

q := parsed.Query()

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'zr' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_parse.go

Line 134 in 934af7f

zr, err := zip.OpenReader(a.path)

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rc' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_parse.go

Line 145 in 934af7f

rc, err := entry.Open()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_build.go

Line 81 in 934af7f

defer func() { _ = arc.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_build.go

Line 114 in 934af7f

for i, item := range playlist.Items {

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_build.go

Line 119 in 934af7f

cues = append(cues, itemCues...)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with declarations or returns (wsl)

vbs/cmd/plt_build.go

Line 404 in 934af7f

    
           pltBuildCmd.Flags().StringVar(&mediaAPI, "media-api", "", "media API base URL (overrides config key plt.mediaapi)")

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_build_integration_test.go

Line 73 in 934af7f

    
           t.Cleanup(func() { pltBuildOut = "."; pltBuildResolution = "720p"; pltBuildLang = "" })

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_build_integration_test.go

Line 79 in 934af7f

t.Cleanup(func() { _ = arc.Close() })

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_clips.go

Line 63 in 934af7f

cur.markers = append(cur.markers, m)

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips.go

Line 104 in 934af7f

for _, line := range strings.Split(strings.TrimSpace(string(out)), "\n") {

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 152 in 934af7f

defer func() { _ = in.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 30 in 934af7f

for _, tool := range []string{"ffmpeg", "ffprobe"} {

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 87 in 934af7f

makeTestVideo(t, src, 10)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_cuesheet.go

Line 124 in 934af7f

fmt.Fprintf(&b, " [%d], [#%s], [%s \\ #raw(%q)], [%s], [%s], [%d], [%s],\n",

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_media.go

Line 156 in 934af7f

var side mediaSidecar

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_media_test.go

Line 65 in 934af7f

for k, want := range tc.wantParams {

statik · 2026-06-11T18:43:44Z

+	defer func() { _ = resp.Body.Close() }()
+
+	if resp.StatusCode != http.StatusOK {
+		return out, fmt.Errorf("media API returned status %d for %+v", resp.StatusCode, *loc)


🚫 [golangci] _{reported by reviewdog 🐶}
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("media API returned status %d for %+v", resp.StatusCode, *loc)" (err113)

statik · 2026-06-11T18:43:44Z

+func selectRendition(resp mediaResponse, langCode, resolution string) (mediaItem, bool, error) {
+	lang, ok := resp.Files[langCode]
+	if !ok || len(lang.MP4) == 0 {
+		return mediaItem{}, false, fmt.Errorf("no MP4 renditions for language %q", langCode)


🚫 [golangci] _{reported by reviewdog 🐶}
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("no MP4 renditions for language %q", langCode)" (err113)

statik · 2026-06-11T18:43:44Z

+	defer func() { _ = resp.Body.Close() }()
+
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("download for %s returned status %d", url, resp.StatusCode)


🚫 [golangci] _{reported by reviewdog 🐶}
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("download for %s returned status %d", url, resp.StatusCode)" (err113)

statik · 2026-06-11T18:43:44Z

+	}
+
+	if wantSize > 0 && size != wantSize {
+		return fmt.Errorf("size mismatch for %s: got %d, want %d", url, size, wantSize)


🚫 [golangci] _{reported by reviewdog 🐶}
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("size mismatch for %s: got %d, want %d", url, size, wantSize)" (err113)

statik · 2026-06-11T18:43:44Z

+	if wantChecksum != "" {
+		got := hex.EncodeToString(hash.Sum(nil))
+		if got != wantChecksum {
+			return fmt.Errorf("checksum mismatch for %s: got %s, want %s", url, got, wantChecksum)


🚫 [golangci] _{reported by reviewdog 🐶}
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("checksum mismatch for %s: got %s, want %s", url, got, wantChecksum)" (err113)

statik · 2026-06-11T18:43:44Z

+				}
+			},
+		},
+		{


🚫 [golangci] _{reported by reviewdog 🐶}
cmd. is missing field check (exhaustruct)

statik · 2026-06-11T18:43:45Z

+			markers:    []Marker{mk("v1", 2.0, 10.0, 0), mk("v2", 15.0, 10.0, 0)},
+			wantRanges: 2,
+		},
+		{


🚫 [golangci] _{reported by reviewdog 🐶}
cmd. is missing field check (exhaustruct)

statik · 2026-06-11T18:43:45Z

+		},
+		{
+			name:       "docid",
+			loc:        Location{DocumentID: 1112024040, Track: 1, Type: 3},


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.Location is missing fields MajorMultimediaType, BaseDurationTicks, BookNumber, ChapterNumber, KeySymbol, MepsLanguage (exhaustruct)

statik · 2026-06-11T18:43:45Z

+}
+
+func TestBuildMediaURL_UnsupportedShape(t *testing.T) {
+	_, err := buildMediaURL("https://example.invalid/api", "ASL", &Location{Type: 9})


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.Location is missing fields MajorMultimediaType, BaseDurationTicks, BookNumber, ChapterNumber, DocumentID, Track, KeySymbol, MepsLanguage (exhaustruct)

statik · 2026-06-11T18:43:45Z

+	})
+	mux.HandleFunc("/", func(w http.ResponseWriter, _ *http.Request) {
+		resp := mediaResponse{Files: map[string]mediaLang{
+			"ASL": {MP4: []mediaItem{{


🚫 [golangci] _{reported by reviewdog 🐶}
string ASL has 7 occurrences, make it a constant (goconst)

statik

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 5, in detected (mnd)

vbs/cmd/plt_clips.go

Line 90 in 9806b02

from := startSec - 5

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0.1, in detected (mnd)

vbs/cmd/plt_clips.go

Line 94 in 9806b02

interval := fmt.Sprintf("%.3f%%%.3f", from, startSec+0.1)

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 2, in detected (mnd)

vbs/cmd/plt_clips.go

Line 106 in 9806b02

if len(fields) < 2 {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 77 in 9806b02

if err := os.WriteFile(path, append(data, '\n'), 0o600); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 60, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 88 in 9806b02

minutes := int(seconds) / 60

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 60, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 89 in 9806b02

rem := seconds - float64(minutes*60)

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

vbs/cmd/plt_cuesheet.go

Line 146 in 9806b02

    
           if err := os.WriteFile(typPath, []byte(renderCueSheet(manifest)), 0o600); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o755, in detected (mnd)

vbs/cmd/plt_media.go

Line 120 in 9806b02

if err := os.MkdirAll(cacheDir, 0o755); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

vbs/cmd/plt_media.go

Line 214 in 9806b02

if err := os.WriteFile(dest+".json", data, 0o600); err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
continue with no blank line before (nlreturn)

vbs/cmd/plt_clips.go

Line 64 in 9806b02

continue

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel (paralleltest)

vbs/cmd/plt_cache_test.go

Line 45 in 9806b02

func TestDownloadAndVerify(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_cache_test.go

Line 50 in 9806b02

t.Run("good size and checksum", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_cache_test.go

Line 57 in 9806b02

t.Run("checksum mismatch is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_cache_test.go

Line 64 in 9806b02

t.Run("size mismatch is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFetchToCache_ReusesCache missing the call to method parallel (paralleltest)

vbs/cmd/plt_cache_test.go

Line 72 in 9806b02

func TestFetchToCache_ReusesCache(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFetchMedia_ParsesRenditions missing the call to method parallel (paralleltest)

vbs/cmd/plt_client_test.go

Line 65 in 9806b02

func TestFetchMedia_ParsesRenditions(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel (paralleltest)

vbs/cmd/plt_client_test.go

Line 78 in 9806b02

func TestSelectRendition(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 85 in 9806b02

t.Run("exact 720p", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 98 in 9806b02

t.Run("absent resolution falls back to highest", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 111 in 9806b02

t.Run("missing language is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestProbeKeyframeBefore_Integration missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 65 in 9806b02

func TestProbeKeyframeBefore_Integration(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestCutVerseClip_Integration missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 81 in 9806b02

func TestCutVerseClip_Integration(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestArchiveExtractEntry missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 109 in 9806b02

func TestArchiveExtractEntry(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMergeMarkers missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_test.go

Line 30 in 9806b02

func TestMergeMarkers(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Range statement for test TestMergeMarkers missing the call to method parallel in test Run (paralleltest)

vbs/cmd/plt_clips_test.go

Line 79 in 9806b02

for _, tc := range cases {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFormatTimecode missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 57 in 9806b02

func TestFormatTimecode(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestWritePlaylistJSON_RoundTrips missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 72 in 9806b02

func TestWritePlaylistJSON_RoundTrips(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestRenderCueSheet missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 100 in 9806b02

func TestRenderCueSheet(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildMediaURL missing the call to method parallel (paralleltest)

vbs/cmd/plt_media_test.go

Line 22 in 9806b02

func TestBuildMediaURL(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Range statement for test TestBuildMediaURL missing the call to method parallel in test Run (paralleltest)

vbs/cmd/plt_media_test.go

Line 54 in 9806b02

for _, tc := range cases {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildMediaURL_UnsupportedShape missing the call to method parallel (paralleltest)

vbs/cmd/plt_media_test.go

Line 79 in 9806b02

func TestBuildMediaURL_UnsupportedShape(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 41 in 9806b02

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 51 in 9806b02

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 71 in 9806b02

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 204 in 9806b02

rm, err := ctx.resolveMedia(item.Location)

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 243 in 9806b02

item Item, index int, slug string, rm resolvedMedia, sourceRel, thumb string,

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'r' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 273 in 9806b02

for i, r := range ranges {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 337 in 9806b02

func (ctx *buildContext) ensureMediaCopy(rm resolvedMedia) (string, error) {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'w' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build_integration_test.go

Line 41 in 9806b02

mux.HandleFunc("/", func(w http.ResponseWriter, _ *http.Request) {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_clips.go

Line 55 in 9806b02

for _, m := range sorted {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'in' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_clips.go

Line 148 in 9806b02

in, err := os.Open(src)

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 95 in 9806b02

var b strings.Builder

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'q' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_media_test.go

Line 64 in 9806b02

q := parsed.Query()

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'zr' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_parse.go

Line 134 in 9806b02

zr, err := zip.OpenReader(a.path)

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rc' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_parse.go

Line 145 in 9806b02

rc, err := entry.Open()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_build.go

Line 84 in 9806b02

defer func() { _ = arc.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_build.go

Line 117 in 9806b02

for i, item := range playlist.Items {

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_build.go

Line 122 in 9806b02

cues = append(cues, itemCues...)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with declarations or returns (wsl)

vbs/cmd/plt_build.go

Line 407 in 9806b02

    
           pltBuildCmd.Flags().StringVar(&mediaAPI, "media-api", "", "media API base URL (overrides config key plt.mediaapi)")

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_build_integration_test.go

Line 73 in 9806b02

    
           t.Cleanup(func() { pltBuildOut = "."; pltBuildResolution = "720p"; pltBuildLang = "" })

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_build_integration_test.go

Line 79 in 9806b02

t.Cleanup(func() { _ = arc.Close() })

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_clips.go

Line 63 in 9806b02

cur.markers = append(cur.markers, m)

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips.go

Line 104 in 9806b02

for _, line := range strings.Split(strings.TrimSpace(string(out)), "\n") {

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 158 in 9806b02

defer func() { _ = out.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 30 in 9806b02

for _, tool := range []string{"ffmpeg", "ffprobe"} {

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 87 in 9806b02

makeTestVideo(t, src, 10)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_cuesheet.go

Line 124 in 9806b02

fmt.Fprintf(&b, " [%d], [#%s], [%s \\ #raw(%q)], [%s], [%s], [%d], [%s],\n",

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_media.go

Line 156 in 9806b02

var side mediaSidecar

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_media_test.go

Line 65 in 9806b02

for k, want := range tc.wantParams {

statik · 2026-06-11T19:50:41Z

+	pltBuildResolution string
+)
+
+var pltBuildCmd = &coral.Command{


🚫 [golangci] _{reported by reviewdog 🐶}
coral.Command is missing fields Aliases, SuggestFor, ValidArgs, ValidArgsFunction, ArgAliases, BashCompletionFunction, Deprecated, Annotations, Version, PersistentPreRun, PersistentPreRunE, PreRun, PreRunE, RunE, PostRun, PostRunE, PersistentPostRun, PersistentPostRunE, FParseErrWhitelist, CompletionOptions, TraverseChildren, Hidden, SilenceErrors, SilenceUsage, DisableFlagParsing, DisableAutoGenTag, DisableFlagsInUseLine, DisableSuggestions, SuggestionsMinimumDistance (exhaustruct)

statik · 2026-06-11T19:50:41Z

+func TestFetchMedia_ParsesRenditions(t *testing.T) {
+	srv := mediaTestServer(t, sanitizedMediaJSON)
+
+	resp, err := fetchMedia(srv.Client(), srv.URL, "ASL", &Location{KeySymbol: "sjj", Track: 135})


🚫 [golangci] _{reported by reviewdog 🐶}
string sjj has 6 occurrences, make it a constant (goconst)

statik · 2026-06-11T19:50:41Z

+// then a document id. Anything else is an error naming the row.
+func classifyLocation(loc *Location) (shapeKind, error) {
+	switch {
+	case loc.KeySymbol == "nwt" && loc.BookNumber > 0:


🚫 [golangci] _{reported by reviewdog 🐶}
string nwt has 4 occurrences, make it a constant (goconst)

statik · 2026-06-11T19:50:41Z

+	}{
+		{
+			name:       "pub track",
+			loc:        Location{KeySymbol: "sjj", Track: 135, Type: 0},


🚫 [golangci] _{reported by reviewdog 🐶}
string sjj has 6 occurrences, make it a constant (goconst)

statik · 2026-06-11T19:50:41Z

+			name:       "pub track",
+			loc:        Location{KeySymbol: "sjj", Track: 135, Type: 0},
+			wantParams: map[string]string{"output": "json", "fileformat": "mp4", "langwritten": "ASL", "pub": "sjj", "track": "135"},
+			forbidden:  []string{"booknum", "docid"},


🚫 [golangci] _{reported by reviewdog 🐶}
string booknum has 3 occurrences, make it a constant (goconst)

statik · 2026-06-11T19:50:42Z

+}
+
+// mediaFileServer serves fixed bytes at any path and counts requests.
+func mediaFileServer(t *testing.T, body []byte) (*httptest.Server, *int32) {


🚫 [golangci] _{reported by reviewdog 🐶}
unnamedResult: consider giving a name to these results (gocritic)

statik · 2026-06-11T19:50:42Z

+}
+
+// downloadAndVerify downloads url to dest and checks size and MD5 (when known).
+func downloadAndVerify(client *http.Client, url, dest string, wantSize int64, wantChecksum string) error {


🚫 [golangci] _{reported by reviewdog 🐶}
importShadow: shadow of imported package 'url' (gocritic)

statik · 2026-06-11T19:50:42Z

+	}
+
+	duration := endSec - keyframe
+	cmd := exec.Command("ffmpeg", "-loglevel", "error",


🚫 [golangci] _{reported by reviewdog 🐶}
G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

statik · 2026-06-11T19:50:42Z

+func makeTestVideo(t *testing.T, path string, durationSec int) {
+	t.Helper()
+
+	cmd := exec.Command("ffmpeg", "-loglevel", "error", "-f", "lavfi",


🚫 [golangci] _{reported by reviewdog 🐶}
G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

statik · 2026-06-11T19:50:42Z

+	}
+	defer func() { _ = out.Close() }()
+
+	if _, err := io.Copy(out, rc); err != nil {


🚫 [golangci] _{reported by reviewdog 🐶}
G110: Potential DoS vulnerability via decompression bomb (gosec)

statik

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 98 in c8c75f6

t.Run("absent resolution falls back to highest", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

vbs/cmd/plt_client_test.go

Line 111 in c8c75f6

t.Run("missing language is an error", func(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestProbeKeyframeBefore_Integration missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 65 in c8c75f6

func TestProbeKeyframeBefore_Integration(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestCutVerseClip_Integration missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 81 in c8c75f6

func TestCutVerseClip_Integration(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestArchiveExtractEntry missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_integration_test.go

Line 109 in c8c75f6

func TestArchiveExtractEntry(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMergeMarkers missing the call to method parallel (paralleltest)

vbs/cmd/plt_clips_test.go

Line 30 in c8c75f6

func TestMergeMarkers(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Range statement for test TestMergeMarkers missing the call to method parallel in test Run (paralleltest)

vbs/cmd/plt_clips_test.go

Line 79 in c8c75f6

for _, tc := range cases {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFormatTimecode missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 57 in c8c75f6

func TestFormatTimecode(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestWritePlaylistJSON_RoundTrips missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 72 in c8c75f6

func TestWritePlaylistJSON_RoundTrips(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestRenderCueSheet missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 100 in c8c75f6

func TestRenderCueSheet(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildMediaURL missing the call to method parallel (paralleltest)

vbs/cmd/plt_media_test.go

Line 22 in c8c75f6

func TestBuildMediaURL(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Range statement for test TestBuildMediaURL missing the call to method parallel in test Run (paralleltest)

vbs/cmd/plt_media_test.go

Line 54 in c8c75f6

for _, tc := range cases {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildMediaURL_UnsupportedShape missing the call to method parallel (paralleltest)

vbs/cmd/plt_media_test.go

Line 79 in c8c75f6

func TestBuildMediaURL_UnsupportedShape(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 41 in c8c75f6

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 51 in c8c75f6

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
test helper function should start from t.Helper() (thelper)

vbs/cmd/plt_clips_test.go

Line 71 in c8c75f6

check: func(t *testing.T, ranges []clipRange) {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 200 in c8c75f6

rm, err := ctx.resolveMedia(item.Location)

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 239 in c8c75f6

item Item, index int, slug string, rm resolvedMedia, sourceRel, thumb string,

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'r' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 269 in c8c75f6

for i, r := range ranges {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 333 in c8c75f6

func (ctx *buildContext) ensureMediaCopy(rm resolvedMedia) (string, error) {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'w' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build_integration_test.go

Line 41 in c8c75f6

mux.HandleFunc("/", func(w http.ResponseWriter, _ *http.Request) {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_clips.go

Line 55 in c8c75f6

for _, m := range sorted {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'in' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_clips.go

Line 148 in c8c75f6

in, err := os.Open(src)

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 95 in c8c75f6

var b strings.Builder

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'q' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_media_test.go

Line 64 in c8c75f6

q := parsed.Query()

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'zr' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_parse.go

Line 134 in c8c75f6

zr, err := zip.OpenReader(a.path)

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rc' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_parse.go

Line 145 in c8c75f6

rc, err := entry.Open()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_build.go

Line 113 in c8c75f6

for i, item := range playlist.Items {

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_build.go

Line 118 in c8c75f6

cues = append(cues, itemCues...)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with declarations or returns (wsl)

vbs/cmd/plt_build.go

Line 403 in c8c75f6

    
           pltBuildCmd.Flags().StringVar(&mediaAPI, "media-api", "", "media API base URL (overrides config key plt.mediaapi)")

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_build_integration_test.go

Line 73 in c8c75f6

    
           t.Cleanup(func() { pltBuildOut = "."; pltBuildResolution = "720p"; pltBuildLang = "" })

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_build_integration_test.go

Line 79 in c8c75f6

t.Cleanup(func() { _ = arc.Close() })

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_clips.go

Line 63 in c8c75f6

cur.markers = append(cur.markers, m)

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips.go

Line 104 in c8c75f6

for _, line := range strings.Split(strings.TrimSpace(string(out)), "\n") {

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 152 in c8c75f6

defer func() { _ = in.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 158 in c8c75f6

defer func() { _ = out.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 30 in c8c75f6

for _, tool := range []string{"ffmpeg", "ffprobe"} {

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 87 in c8c75f6

makeTestVideo(t, src, 10)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_cuesheet.go

Line 124 in c8c75f6

fmt.Fprintf(&b, " [%d], [#%s], [%s \\ #raw(%q)], [%s], [%s], [%d], [%s],\n",

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_media.go

Line 68 in c8c75f6

defer func() { _ = resp.Body.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_media.go

Line 156 in c8c75f6

var side mediaSidecar

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_media_test.go

Line 65 in c8c75f6

for k, want := range tc.wantParams {

statik · 2026-06-11T20:24:12Z

+
+	playlist, err := parsePlaylist(arc)
+	if err != nil {
+		log.Fatal().Err(err).Msg("Could not parse playlist")


🚫 [golangci] _{reported by reviewdog 🐶}
exitAfterDefer: log.Fatal will exit, and defer func(){...}(...) will not run (gocritic)

statik · 2026-06-11T20:24:12Z

+
+	outDir := filepath.Join(resolveInputPath(pltBuildOut), slugify(playlist.Name))
+	for _, sub := range []string{"clips", "media", "thumbs"} {
+		if err := os.MkdirAll(filepath.Join(outDir, sub), 0o755); err != nil {


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o755, in detected (mnd)

statik · 2026-06-11T20:24:12Z

+// probeKeyframeBefore returns the presentation time of the last keyframe at or
+// before startSec. Published files use a uniform GOP, but this handles any.
+func probeKeyframeBefore(file string, startSec float64) (float64, error) {
+	from := startSec - 5


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 5, in detected (mnd)

statik · 2026-06-11T20:24:12Z

+	if from < 0 {
+		from = 0
+	}
+	interval := fmt.Sprintf("%.3f%%%.3f", from, startSec+0.1)


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0.1, in detected (mnd)

statik · 2026-06-11T20:24:12Z

+	best := 0.0
+	for _, line := range strings.Split(strings.TrimSpace(string(out)), "\n") {
+		fields := strings.Split(line, ",")
+		if len(fields) < 2 {


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 2, in detected (mnd)

statik · 2026-06-11T20:24:13Z

+		}
+	})
+
+	t.Run("size mismatch is an error", func(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestDownloadAndVerify missing the call to method parallel in the test run (paralleltest)

statik · 2026-06-11T20:24:13Z

+	})
+}
+
+func TestFetchToCache_ReusesCache(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFetchToCache_ReusesCache missing the call to method parallel (paralleltest)

statik · 2026-06-11T20:24:13Z

+	return srv
+}
+
+func TestFetchMedia_ParsesRenditions(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFetchMedia_ParsesRenditions missing the call to method parallel (paralleltest)

statik · 2026-06-11T20:24:13Z

+	}
+}
+
+func TestSelectRendition(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel (paralleltest)

statik · 2026-06-11T20:24:13Z

+		t.Fatalf("fetchMedia: %v", err)
+	}
+
+	t.Run("exact 720p", func(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

statik

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_build_integration_test.go

Line 73 in 97b7967

    
           t.Cleanup(func() { pltBuildOut = "."; pltBuildResolution = "720p"; pltBuildLang = "" })

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_build_integration_test.go

Line 79 in 97b7967

t.Cleanup(func() { _ = arc.Close() })

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_clips.go

Line 63 in 97b7967

cur.markers = append(cur.markers, m)

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips.go

Line 104 in 97b7967

for _, line := range strings.Split(strings.TrimSpace(string(out)), "\n") {

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 152 in 97b7967

defer func() { _ = in.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 158 in 97b7967

defer func() { _ = out.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 30 in 97b7967

for _, tool := range []string{"ffmpeg", "ffprobe"} {

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 87 in 97b7967

makeTestVideo(t, src, 10)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_cuesheet.go

Line 124 in 97b7967

fmt.Fprintf(&b, " [%d], [#%s], [%s \\ #raw(%q)], [%s], [%s], [%d], [%s],\n",

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_media.go

Line 68 in 97b7967

defer func() { _ = resp.Body.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_media.go

Line 156 in 97b7967

var side mediaSidecar

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_media_test.go

Line 65 in 97b7967

for k, want := range tc.wantParams {

statik · 2026-06-12T16:01:45Z

+		}
+	})
+
+	t.Run("absent resolution falls back to highest", func(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

statik · 2026-06-12T16:01:45Z

+		}
+	})
+
+	t.Run("missing language is an error", func(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestSelectRendition missing the call to method parallel in the test run (paralleltest)

statik · 2026-06-12T16:01:45Z

+	return d
+}
+
+func TestProbeKeyframeBefore_Integration(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestProbeKeyframeBefore_Integration missing the call to method parallel (paralleltest)

statik · 2026-06-12T16:01:45Z

+	}
+}
+
+func TestCutSegment_Integration(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestCutSegment_Integration missing the call to method parallel (paralleltest)

statik · 2026-06-12T16:01:45Z

+	}
+}
+
+func TestArchiveExtractEntry(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestArchiveExtractEntry missing the call to method parallel (paralleltest)

statik · 2026-06-12T16:01:46Z

+			if err != nil {
+				t.Fatalf("result is not a URL: %v", err)
+			}
+			q := parsed.Query()


🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'q' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T16:01:46Z

+// the caller (derived from item order and slug), never from the entry name, so
+// there is no zip-slip exposure; the entry name only locates the source bytes.
+func (a *archive) extractEntry(entryName, destPath string) error {
+	zr, err := zip.OpenReader(a.path)


🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'zr' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T16:01:46Z

+		return fmt.Errorf("zip entry %q not found in archive", entryName)
+	}
+
+	rc, err := entry.Open()


🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rc' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T16:01:46Z

+
+	var cues []cue
+	seen := map[string]int{}
+	for i, item := range playlist.Items {


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

statik · 2026-06-12T16:01:46Z

+		if err != nil {
+			return buildManifest{}, fmt.Errorf("item %d (%q): %w", i+1, item.Label, err)
+		}
+		cues = append(cues, itemCues...)


🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

statik

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildCueSheetOnly_NoMedia missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 25 in 2eb803b

func TestBuildCueSheetOnly_NoMedia(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestEndActionLabel missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 133 in 2eb803b

func TestEndActionLabel(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFormatTimecode missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 142 in 2eb803b

func TestFormatTimecode(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestWritePlaylistJSON_RoundTrips missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 157 in 2eb803b

func TestWritePlaylistJSON_RoundTrips(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
Function TestRenderCueSheet missing the call to method parallel (paralleltest)

vbs/cmd/plt_cuesheet_test.go

Line 185 in 2eb803b

func TestRenderCueSheet(t *testing.T) {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'it' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt.go

Line 179 in 2eb803b

func itemMediaURL(it Item, base string) string {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 254 in 2eb803b

var b strings.Builder

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 292 in 2eb803b

    
           func writeCueSheetPreamble(b *strings.Builder, manifest buildManifest, total float64) {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'c' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 329 in 2eb803b

func cueSheetRow(c cue, elapsed, maxDur float64) string {

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt.go

Line 294 in 2eb803b

for _, it := range view.Items {

🚫 [golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments (wsl)

vbs/cmd/plt.go

Line 299 in 2eb803b

if len(withURL) == 0 {

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt.go

Line 306 in 2eb803b

for _, it := range withURL {

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with declarations or returns (wsl)

vbs/cmd/plt_build.go

Line 409 in 2eb803b

    
           pltBuildCmd.Flags().StringVar(&mediaAPI, "media-api", "", "media API base URL (overrides config key plt.mediaapi)")

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_build_integration_test.go

Line 73 in 2eb803b

    
           t.Cleanup(func() { pltBuildOut = "."; pltBuildResolution = "720p"; pltBuildLang = "" })

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_build_integration_test.go

Line 79 in 2eb803b

t.Cleanup(func() { _ = arc.Close() })

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

vbs/cmd/plt_clips.go

Line 63 in 2eb803b

cur.markers = append(cur.markers, m)

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

vbs/cmd/plt_clips.go

Line 104 in 2eb803b

for _, line := range strings.Split(strings.TrimSpace(string(out)), "\n") {

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 152 in 2eb803b

defer func() { _ = in.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_clips.go

Line 158 in 2eb803b

defer func() { _ = out.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_clips_integration_test.go

Line 87 in 2eb803b

makeTestVideo(t, src, 10)

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

vbs/cmd/plt_cuesheet.go

Line 66 in 2eb803b

log.Info().Msgf("Wrote cue sheet into %s", outDir)

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_cuesheet.go

Line 85 in 2eb803b

for i, item := range playlist.Items {

🚫 [golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments used in the if statement itself (wsl)

vbs/cmd/plt_cuesheet.go

Line 259 in 2eb803b

if c.DurationSec > maxDur {

🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

vbs/cmd/plt_cuesheet_test.go

Line 40 in 2eb803b

    
           t.Cleanup(func() { pltCuesheetOut = "."; pltCuesheetResolution = "720p"; pltCuesheetLang = "" })

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_cuesheet_test.go

Line 69 in 2eb803b

for _, dir := range []string{"media", "clips"} {

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_cuesheet_test.go

Line 82 in 2eb803b

var manifest buildManifest

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

vbs/cmd/plt_media.go

Line 68 in 2eb803b

defer func() { _ = resp.Body.Close() }()

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_media.go

Line 156 in 2eb803b

var side mediaSidecar

statik · 2026-06-12T19:35:17Z


 	"github.com/muesli/coral"
 	"github.com/rs/zerolog/log"
+	"github.com/spf13/viper"


🚫 [golangci] _{reported by reviewdog 🐶}
import 'github.com/spf13/viper' is not allowed from list 'Main' (depguard)

statik · 2026-06-12T19:35:17Z

+	pltCuesheetResolution string
+)
+
+var pltCuesheetCmd = &coral.Command{


🚫 [golangci] _{reported by reviewdog 🐶}
coral.Command is missing fields Aliases, SuggestFor, ValidArgs, ValidArgsFunction, ArgAliases, BashCompletionFunction, Deprecated, Annotations, Version, PersistentPreRun, PersistentPreRunE, PreRun, PreRunE, RunE, PostRun, PostRunE, PersistentPostRun, PersistentPostRunE, FParseErrWhitelist, CompletionOptions, TraverseChildren, Hidden, SilenceErrors, SilenceUsage, DisableFlagParsing, DisableAutoGenTag, DisableFlagsInUseLine, DisableSuggestions, SuggestionsMinimumDistance (exhaustruct)

statik · 2026-06-12T19:35:17Z

+)
+
+func TestBuildCueSheetOnly_NoMedia(t *testing.T) {
+	arc, err := sniffPlaylist(writePlaylistFixture(t, fixtureOptions{}))


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.fixtureOptions is missing fields schemaVersion, omitTables, omitManifest, notZip, corruptDB, databaseName (exhaustruct)

statik · 2026-06-12T19:35:17Z

+	mux.HandleFunc("/", func(w http.ResponseWriter, _ *http.Request) {
+		resp := mediaResponse{Files: map[string]mediaLang{
+			"ASL": {MP4: []mediaItem{{
+				Title: "synthetic", Label: "720p",


🚫 [golangci] _{reported by reviewdog 🐶}
string 720p has 9 occurrences, make it a constant (goconst)

statik · 2026-06-12T19:35:17Z

+	cacheDir := t.TempDir()
+
+	item := mediaItem{
+		Label:    "720p",


🚫 [golangci] _{reported by reviewdog 🐶}
string 720p has 9 occurrences, make it a constant (goconst)

statik · 2026-06-12T19:35:17Z

+		if !fellBack {
+			t.Error("1080p is absent; should fall back")
+		}
+		if item.Label != "720p" || item.FrameHeight != 720 {


🚫 [golangci] _{reported by reviewdog 🐶}
string 720p has 9 occurrences, make it a constant (goconst)

statik · 2026-06-12T19:35:18Z

+
+	playlist, err := parsePlaylist(arc)
+	if err != nil {
+		log.Fatal().Err(err).Msg("Could not parse playlist")


🚫 [golangci] _{reported by reviewdog 🐶}
exitAfterDefer: log.Fatal will exit, and defer func(){...}(...) will not run (gocritic)

statik · 2026-06-12T19:35:18Z

+
+// buildCueSheetOnly assembles cue metadata from the playlist alone — no media
+// downloads, no clip cutting — and writes playlist.json plus the cue sheet.
+func buildCueSheetOnly(arc *archive, playlist *Playlist) (string, bool, error) {


🚫 [golangci] _{reported by reviewdog 🐶}
unnamedResult: consider giving a name to these results (gocritic)

statik · 2026-06-12T19:35:18Z

+	}
+
+	outDir := filepath.Join(resolveInputPath(pltCuesheetOut), slugify(playlist.Name))
+	if err := os.MkdirAll(filepath.Join(outDir, "thumbs"), 0o755); err != nil {


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o755, in detected (mnd)

statik · 2026-06-12T19:51:03Z

+	"testing"
+)
+
+func TestBuildCueSheetOnly_NoMedia(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestBuildCueSheetOnly_NoMedia missing the call to method parallel (paralleltest)

statik · 2026-06-12T19:51:03Z

+// itemMediaURL builds the media API query URL an item resolves to, derived from
+// its catalog keys. Image cues and unsupported shapes have no URL. When base is
+// empty the placeholder "<plt.mediaapi>" stands in for the configured endpoint.
+func itemMediaURL(it Item, base string) string {


🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'it' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T19:51:03Z

+
+// renderMediaURLs prints the media API query URL each item resolves to, derived
+// from the playlist's catalog keys.
+func renderMediaURLs(w io.Writer, view printView) error {


🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'w' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T19:51:03Z

+// from the playlist's catalog keys.
+func renderMediaURLs(w io.Writer, view printView) error {
+	var withURL []printItem
+	for _, it := range view.Items {


🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

statik · 2026-06-12T19:51:03Z

+	if _, err := fmt.Fprint(w, "\nMedia URLs:\n"); err != nil {
+		return fmt.Errorf("could not write media URL header: %w", err)
+	}
+	for _, it := range withURL {


🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

statik · 2026-06-12T19:51:04Z

+	if err != nil {
+		return fmt.Errorf("could not create %s: %w", dst, err)
+	}
+	defer func() { _ = out.Close() }()


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

statik · 2026-06-12T19:51:04Z

+	dir := t.TempDir()
+	src := filepath.Join(dir, "src.mp4")
+	out := filepath.Join(dir, "clip.mp4")
+	makeTestVideo(t, src, 10)


🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

statik · 2026-06-12T19:51:04Z

+	if !pdf {
+		log.Info().Msg("typst not found on PATH; wrote cuesheet.typ only (install typst to render cuesheet.pdf)")
+	}
+	log.Info().Msgf("Wrote cue sheet into %s", outDir)


🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

statik · 2026-06-12T19:51:04Z

+	pltCuesheetOut = out
+	pltCuesheetResolution = "720p"
+	pltCuesheetLang = ""
+	t.Cleanup(func() { pltCuesheetOut = "."; pltCuesheetResolution = "720p"; pltCuesheetLang = "" })


🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

statik · 2026-06-12T19:51:04Z

+	if err != nil {
+		return false
+	}
+	var side mediaSidecar


🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

statik

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 214 in 19bb0d1

rm, err := ctx.resolveMedia(item.Location)

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 253 in 19bb0d1

item Item, index int, slug string, rm resolvedMedia, sourceRel, thumb string,

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'r' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_build.go

Line 283 in 19bb0d1

for i, r := range ranges {

🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 257 in 19bb0d1

var b strings.Builder

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'b' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 295 in 19bb0d1

    
           func writeCueSheetPreamble(b *strings.Builder, manifest buildManifest, total float64) {

🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'c' is too short for the scope of its usage (varnamelen)

vbs/cmd/plt_cuesheet.go

Line 332 in 19bb0d1

func cueSheetRow(c cue, elapsed, maxDur float64) string {

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with declarations or returns (wsl)

vbs/cmd/plt_build.go

Line 423 in 19bb0d1

    
           pltBuildCmd.Flags().StringVar(&mediaAPI, "media-api", "", "media API base URL (overrides config key plt.mediaapi)")

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_cuesheet.go

Line 88 in 19bb0d1

for i, item := range playlist.Items {

🚫 [golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments used in the if statement itself (wsl)

vbs/cmd/plt_cuesheet.go

Line 262 in 19bb0d1

if c.DurationSec > maxDur {

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

vbs/cmd/plt_cuesheet_test.go

Line 73 in 19bb0d1

for _, dir := range []string{"media", "clips"} {

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

vbs/cmd/plt_cuesheet_test.go

Line 86 in 19bb0d1

var manifest buildManifest

statik · 2026-06-12T19:55:37Z

+		return ctx.imageCue(item, index, slug, thumb)
+	}
+	if item.Location == nil {
+		return nil, fmt.Errorf("video item has no catalog location")


🚫 [golangci] _{reported by reviewdog 🐶}
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("video item has no catalog location")" (err113)

statik · 2026-06-12T19:55:37Z

+	if err := ctx.arc.extractEntry(item.Image.FilePath, filepath.Join(ctx.outDir, clipRel)); err != nil {
+		return nil, err
+	}
+	return []cue{{


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.cue is missing fields SourceMedia, Markers, Cut (exhaustruct)

statik · 2026-06-12T19:55:37Z

+	if duration == 0 {
+		duration = ticksToSeconds(item.Location.BaseDurationTicks)
+	}
+	return []cue{{


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.cue is missing fields Markers, Cut (exhaustruct)

statik · 2026-06-12T19:55:37Z

+// trimRange turns an item's trim offsets into a single clip range, when set.
+func trimRange(item Item) (clipRange, bool) {
+	if item.StartTrimTicks == 0 && item.EndTrimTicks == 0 {
+		return clipRange{}, false


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.clipRange is missing fields startTicks, endTicks, markers (exhaustruct)

statik · 2026-06-12T19:55:37Z

+		return clipRange{}, false
+	}
+	if item.Location == nil {
+		return clipRange{}, false


🚫 [golangci] _{reported by reviewdog 🐶}
cmd.clipRange is missing fields startTicks, endTicks, markers (exhaustruct)

statik · 2026-06-12T19:55:38Z

+// cuesheet.pdf. It returns whether a PDF was produced.
+func writeCueSheet(dir string, manifest buildManifest) (bool, error) {
+	typPath := filepath.Join(dir, "cuesheet.typ")
+	if err := os.WriteFile(typPath, []byte(renderCueSheet(manifest)), 0o600); err != nil {


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 0o600, in detected (mnd)

statik · 2026-06-12T19:55:38Z

+	}
+}
+
+func TestEndActionLabel(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestEndActionLabel missing the call to method parallel (paralleltest)

statik · 2026-06-12T19:55:38Z

+	}
+}
+
+func TestFormatTimecode(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestFormatTimecode missing the call to method parallel (paralleltest)

statik · 2026-06-12T19:55:38Z

+	}
+}
+
+func TestWritePlaylistJSON_RoundTrips(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestWritePlaylistJSON_RoundTrips missing the call to method parallel (paralleltest)

statik · 2026-06-12T19:55:38Z

+	}
+}
+
+func TestRenderCueSheet(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestRenderCueSheet missing the call to method parallel (paralleltest)

Build a self-contained working directory from a purple playlist: resolve each catalog location to a media-API query, download renditions (default 720p) to a shared cache with MD5 + size verification, pre-cut verse clips with a keyframe-snapped stream copy (no re-encode), extract image cues and thumbnails, and emit playlist.json plus a Typst cue sheet (compiled to PDF when typst is present). Distinct locations are fetched once and downloads are cached, so re-running is fast and deterministic. The media endpoint is config-only (plt.mediaapi) and fails fast with an actionable message when unset. Verified against the example export: 15 cues, media deduped to 10 files, every verse clip starts within one GOP of its marker, re-run hits the cache.

Apply the same help example and BUILD_WORKING_DIRECTORY path resolution to plt build: the playlist argument and --out are now resolved against the invoking directory under 'bazel run'.

Derive and print the media-API query URL per item from its catalog keys (pub/track, book/chapter, docid) plus the configured plt.mediaapi base. Stays offline: image cues have no URL, and when the endpoint is unset a <plt.mediaapi> placeholder shows the playlist-derived query. Added to both the text output (a Media URLs section) and the JSON view.

Generate playlist.json, cuesheet.typ, extracted thumbnails, and (when typst is installed) cuesheet.pdf straight from the playlist — no media downloads, no clip cutting, no ffmpeg or media API. Durations come from the catalog ticks and markers; the lead-in column is left blank since keyframe snapping needs the real video files. Thumbnail extraction is now shared with build.

The lead-in is a build-time keyframe-snapping detail with no action for the technical director, and was blank in offline cue sheets anyway. The value is still recorded in playlist.json for the Phase 3 .mitti transform.

Give the cue sheet an editorial, workbook-style layout: clean sans-serif, a header band, near-borderless rows with single-color cue numbers, and a footer rule. Interpret the after-cue action codes (0 continue, 1 stop, 2 freeze) in both the cue sheet and the plt print table, now that their meanings are confirmed.

Bring back a small proportional duration sparkline per cue, and move the running elapsed time under the duration as quiet gray text so it no longer needs its own column.

Linear bars were dominated by the single longest cue, leaving the short cues indistinguishable. A square-root scale spreads them out while the longest cue still reads as the longest.

Write a .gitignore ("*") into every build/cuesheet working directory so the generated output (clips, media, thumbnails, cue sheet, playlist.json) can never be accidentally committed, regardless of the playlist slug or where the command is run.

statik · 2026-06-12T20:06:23Z

+		return nil, fmt.Errorf("video item has no catalog location")
+	}
+
+	rm, err := ctx.resolveMedia(item.Location)


🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'rm' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T20:06:23Z

+
+// wholeVideoCue copies an untrimmed, marker-free video to its ordered clip.
+func (ctx *buildContext) wholeVideoCue(
+	item Item, index int, slug string, rm resolvedMedia, sourceRel, thumb string,


🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'rm' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T20:06:23Z

+	srcPath := filepath.Join(ctx.outDir, sourceRel)
+
+	cues := make([]cue, 0, len(ranges))
+	for i, r := range ranges {


🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'r' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T20:06:23Z

+// a clean sans-serif, near-borderless layout with color-coded cue numbers, a
+// header band, and a footer rule — echoing the meeting-workbook style.
+func renderCueSheet(manifest buildManifest) string {
+	var b strings.Builder


🚫 [golangci] _{reported by reviewdog 🐶}
variable name 'b' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T20:06:23Z

+
+// writeCueSheetPreamble emits the page setup (with a footer rule), the title
+// band, and the muted metadata line.
+func writeCueSheetPreamble(b *strings.Builder, manifest buildManifest, total float64) {


🚫 [golangci] _{reported by reviewdog 🐶}
parameter name 'b' is too short for the scope of its usage (varnamelen)

statik · 2026-06-12T20:06:24Z

+
+	var cues []cue
+	seen := map[string]int{}
+	for i, item := range playlist.Items {


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

statik · 2026-06-12T20:06:24Z

+	total, maxDur := 0.0, 0.0
+	for _, c := range manifest.Cues {
+		total += c.DurationSec
+		if c.DurationSec > maxDur {


🚫 [golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments used in the if statement itself (wsl)

statik · 2026-06-12T20:06:24Z

+	if entries, _ := os.ReadDir(filepath.Join(workDir, "thumbs")); len(entries) == 0 {
+		t.Error("expected extracted thumbnails")
+	}
+	for _, dir := range []string{"media", "clips"} {


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

statik · 2026-06-12T20:06:24Z

+	if err != nil {
+		t.Fatalf("read %s: %v", path, err)
+	}
+	var manifest buildManifest


🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

statik · 2026-06-12T20:06:24Z

+	if err != nil {
+		return fmt.Errorf("download failed for %s: %w", url, err)
+	}
+	defer func() { _ = resp.Body.Close() }()


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before defer statement (wsl)

Plan covers the port of vbs plt cuesheet generation (kindlyops/vbs#887) to a hexagonal Rust core with Typst linked as a library, a Tufte-styled Tauri 2 GUI using the Fantastic Mr Fox palette, license attribution via cargo-about, and a tag-driven release pipeline with gated code signing and the Tauri updater. https://claude.ai/code/session_01Sn1jjXDRydhdL4AGnkWNGQ

* Add detailed build plan for Cuesheet Tauri app Plan covers the port of vbs plt cuesheet generation (kindlyops/vbs#887) to a hexagonal Rust core with Typst linked as a library, a Tufte-styled Tauri 2 GUI using the Fantastic Mr Fox palette, license attribution via cargo-about, and a tag-driven release pipeline with gated code signing and the Tauri updater. https://claude.ai/code/session_01Sn1jjXDRydhdL4AGnkWNGQ * Add GitHub Pages site (three.js red panda diorama) to plan https://claude.ai/code/session_01Sn1jjXDRydhdL4AGnkWNGQ --------- Co-authored-by: Claude <noreply@anthropic.com>

statik added the feature label Jun 11, 2026

statik commented Jun 11, 2026

View reviewed changes

statik force-pushed the plt-phase-2 branch from 934af7f to 9806b02 Compare June 11, 2026 19:50

statik commented Jun 11, 2026

View reviewed changes

statik force-pushed the plt-phase-1 branch from fbf96f6 to 1111b7d Compare June 11, 2026 20:23

statik force-pushed the plt-phase-2 branch from 9806b02 to c8c75f6 Compare June 11, 2026 20:23

statik commented Jun 11, 2026

View reviewed changes

statik force-pushed the plt-phase-1 branch from b48cb2f to 01aa59b Compare June 12, 2026 16:00

statik force-pushed the plt-phase-2 branch from c8c75f6 to 97b7967 Compare June 12, 2026 16:01

statik commented Jun 12, 2026

View reviewed changes

statik force-pushed the plt-phase-2 branch from 2eb803b to 80c06c1 Compare June 12, 2026 19:50

statik commented Jun 12, 2026

View reviewed changes

statik added 10 commits June 12, 2026 16:03

Show file argument in plt build help and resolve its relative paths

a87447b

Apply the same help example and BUILD_WORKING_DIRECTORY path resolution to plt build: the playlist argument and --out are now resolved against the invoking directory under 'bazel run'.

Use openPlaylist in plt build for the clearer not-found message

a5dca0a

Drop the lead-in column from the cue sheet

294c7b5

The lead-in is a build-time keyframe-snapping detail with no action for the technical director, and was blank in offline cue sheets anyway. The value is still recorded in playlist.json for the Phase 3 .mitti transform.

Add duration sparklines and fold elapsed into the duration column

417adff

Bring back a small proportional duration sparkline per cue, and move the running elapsed time under the duration as quiet gray text so it no longer needs its own column.

Use a square-root scale for the duration sparkline

970cfde

Linear bars were dominated by the single longest cue, leaving the short cues indistinguishable. A square-root scale spreads them out while the longest cue still reads as the longest.

statik force-pushed the plt-phase-1 branch from 01aa59b to eb704f8 Compare June 12, 2026 20:05

statik force-pushed the plt-phase-2 branch from 19bb0d1 to 41bdf2f Compare June 12, 2026 20:05

statik commented Jun 12, 2026

View reviewed changes

Base automatically changed from plt-phase-1 to main June 12, 2026 20:12

statik merged commit 4c1f1ce into main Jun 12, 2026
21 checks passed

statik deleted the plt-phase-2 branch June 12, 2026 20:13

statik mentioned this pull request Jun 12, 2026

Build plan: Cuesheet Tauri app kindlyops/cuesheet#1

Merged

Uh oh!

Conversation

statik commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

statik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

statik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

statik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

statik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

statik commented Jun 11, 2026 •

edited

Loading