LBDP destructive sampling: parameter hardening and full BDD(r) inference#2
Open
Horopter wants to merge 1 commit intokingaa:bddrfrom
Open
LBDP destructive sampling: parameter hardening and full BDD(r) inference#2Horopter wants to merge 1 commit intokingaa:bddrfrom
Horopter wants to merge 1 commit intokingaa:bddrfrom
Conversation
Horopter
changed the title
- Parameter hardening: C++ r bounds in src/lbdp.cc, yaml; r and n0 checks in yaml/R/lbdp.R
- Full BDD(r) inference: lbdp_exact general-r likelihood (0<=r<=1), filter docs, R/man docs
- Tests: invalid r, saturation, exact/pfilter for r=0.4, calibration over r in {0,0.5,1}
Horopter
force-pushed
the
codex/attempt-2
branch
2 times, most recently
from
e795585 to
db51862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Parameter hardening
rinsrc/lbdp.ccandyaml/src/lbdp.cc(0 <= r <= 1).randn0validation inyaml/R/lbdp.RforrunLBDPandcontinueLBDP.Full BDD(r) inference (0 ≤ r ≤ 1)
R/lbdp_exact.R): General-r formula using saturation (non-destructive vs destructive samples). Removedr == 0restriction;lbdp_exactnow accepts0 <= r <= 1.src/lbdp_pomp.c): Comment that the filter supports BDD(r). Logic was already r-aware; no behavioral change.R/lbdp.R,R/lbdp_exact.R,man/lbdp.Rdupdated so destructive sampling is documented for both exact and pfilter inference.Tests (
tests/lbdp4.R)rstill rejected (try blocks).lbdp_exactandlbdp_pomp(pfilter) return finite likelihood for r=0.4.Why
Completes BDD(r) support on the
bddrbranch: hardening forrandn0, plus inference (exact and particle filter) for0 <= r <= 1, with tests ensuring exact and pfilter agree.Validation
R CMD INSTALL .Rscript tests/lbdp4.R