Reduce duplicate test code with centralized TEST_FILE_PATH constant - #191
Merged
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Co-authored-by: PythonFZ <46721498+PythonFZ@users.noreply.github.com>
PythonFZ
reviewed
Oct 20, 2025
Copilot
AI
changed the title
[WIP] Refactor test code to reduce duplication
Reduce duplicate test code with centralized TEST_FILE_PATH constant
Oct 20, 2025
PythonFZ
marked this pull request as ready for review
October 21, 2025 08:06
arm61
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Test files throughout the codebase contained significant code duplication with the same path construction pattern repeated 30+ times:
This approach had several drawbacks:
os.pathinstead of modernpathlibSolution
Implemented @PythonFZ's suggestion to create a centralized
TEST_FILE_PATHconstant:kinisi/tests/__init__.py:Benefits
/operatorpathlib.Pathinstead ofos.pathoperationsChanges
TEST_FILE_PATHconstant inkinisi/tests/__init__.pytest_analyzer.py,test_ase.py,test_conductivity_analyzer.py,test_diffusion.py,test_diffusion_analyzer.py,test_jump_diffusion_analyzer.py,test_mdanalysis.py,test_parser.py,test_pymatgen.pykinisimodule imports where only used for path constructionCo-authored-by: PythonFZ 46721498+PythonFZ@users.noreply.github.com
Original prompt
Fixes #190
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.