Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release PR title #2987

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Sep 18, 2024

Why

kintone/cli-kintone#866 に合わせてリリースPRのタイトルを変更した。

  • 変更前: chore: release main
  • 変更後: chore: release from main

What

How to test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

Copy link
Member

@shabaraba shabaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tasshi-me
良さそうに思ったのでapproveします!

指摘ではなく質問なのですが、cli-kintoneと同じくchore(${component}): release ${version} from ${branch}としなかった理由はなにかありますか?

@tasshi-me
Copy link
Member Author

@shabaraba
レビューありがとうございます!
こちらjs-sdkはリリースPRに複数パッケージが載る都合上、${component}の部分が空欄になってしまうためscopeを設定していません!

NOTE: tasshi-playground/demo-monorepo-release-please#15 で検証済み

@tasshi-me tasshi-me merged commit c9192f6 into main Sep 25, 2024
17 checks passed
@tasshi-me tasshi-me deleted the chore/update-release-pr-title-pattern branch September 25, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants