feat(plugin-packer): update plugin manifest validator #3146
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: plugin-manifest-validator
chihiro-adachi
commented
Jan 27, 2025
| @@ -29,6 +29,7 @@ module.exports = { | |||
| zlib: require.resolve("browserify-zlib"), | |||
| stream: require.resolve("stream-browserify"), | |||
| constants: require.resolve("constants-browserify"), | |||
| vm: false, | |||
There was a problem hiding this comment.
パッケージできることを確認できたため、フォールバックは vm: false にしています。
chihiro-adachi
requested review from
tasshi-me and
shabaraba
and removed request for
a team
shabaraba
approved these changes
Jan 28, 2025
chihiro-adachi
force-pushed
the
feat-update-manifest-validator
branch
from
4bcc2f4 to
e2cb412
Compare
chihiro-adachi
force-pushed
the
feat-update-manifest-validator
branch
from
e2cb412 to
db229b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#3138 の続きでPRしています。#3138 のマージ後にマージしてください。
This is a continuation of #3138. Please merge this after merging #3138.
What
How to test
cliからパッケージできることを確認.
Confirmed that it can be packaged from cli.
画面UIからパッケージできることを確認.
Confirmed that it is possible to package from the screen UI.
Checklist
pnpm lintandpnpm teston the root directory.