Group property management#2
Open
gjherbiet wants to merge 10 commits into
Open
Conversation
gjherbiet
changed the title
Member
|
Great start! Can we get test coverage as well? Please also see test results. |
jschlyter
reviewed
Jun 1, 2022
| def get_catz_zones(catalog_zone: dns.zone.Zone) -> Dict: | ||
| """Get zones from catalog zone""" | ||
| zones = set() | ||
| zones = {} |
Member
There was a problem hiding this comment.
perhaps use defaultdict(dict) here to rid of the test at line 232?
Member
|
@gjherbiet you can use |
Member
|
I've merged the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements management of the per-zone group property as defined in section 4.4.2 of the draft RFC:
zones2catzthe list of zones can now be a comma-separated text file, where the zone-specific group can be passed as the second value of the line;catz2nsd, the zone-specific group property is used instead of the catalog zone default if it is present.