Ci - Updates#9
Merged
Merged
Conversation
kiritigowda
commented
May 8, 2026
kiritigowda
commented
Owner
- Readme cleanup
- Benchmark for CI
Readme - Updates
Two bugs caused 4 openvx-mark pipelines (EdgeDetection, HistogramEqualize, HarrisTracker, ThresholdedEdge) to fail at vxProcessGraph after vxVerifyGraph succeeded: 1. vxCreateVirtualImage(g, w, h, FORMAT) records dims+format but leaves data = Vec::new(). The verify-time allocation loop saw non-zero dims+format and skipped allocation, so ColorConvert later returned VX_ERROR_INVALID_PARAMETERS when dst_data.len() was 0. Now we only skip dimension *inference* when dims are known and still ensure the data buffer is sized. 2. infer_virtual_image_dimensions ignored the user-specified format on a vxCreateVirtualImage(g, 0, 0, FORMAT) image and re-inferred it from the producer. For a user-declared U8 fed by Magnitude (S16), the image was silently retyped to S16, so the next ConvertDepth(S16->S16) returned VX_ERROR_INVALID_FORMAT. Now we preserve any user-specified non-VIRT format and only infer dimensions from the producer; VX_DF_IMAGE_VIRT is consistently treated as "format unknown". After the fix, openvx-mark reports 52/52 passed, 0 skipped, 0 failed against rustVX (was 48/52 with 4 skipped). Co-authored-by: Cursor <cursoragent@cursor.com>
Benchmark - CI Addition
4 tasks
kiritigowda
added a commit
that referenced
this pull request
May 8, 2026
* docs: fix broken CI badges and fill in README gaps The conformance workflow no longer runs on `develop` (the branch was merged into `main` via PR #9 and removed), so every status badge in the README was rendering as "no status". Repointing all badge URLs at `main` restores them. While here, document Cargo features (simd / sse2 / avx2 / neon / parallel), add a minimal C-side usage and linking snippet, mention the bundled OpenVX headers, surface the existing `cargo test` / Criterion bench / openvx-mark-vs-Khronos-sample workflows, and add a Contributing section. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: skip conformance on docs-only changes; remove APIsec scan - Add `paths-ignore` (`**/*.md`, `docs/**`, `LICENSE`) to both the push and pull_request triggers of the conformance workflow so documentation-only edits no longer spin up the full CTS + benchmark matrix. - Drop the GitHub starter `apisec-scan.yml` workflow. It targeted the unrelated `VAmPI` APIsec project, depended on missing `apisec_username` / `apisec_password` secrets, and was effectively dead weight on every push and pull request. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: note benchmark report in CI job summary and artifacts Point readers at the rustVX-vs-Khronos comparison table that the Benchmark & compare job writes to the GitHub Actions job summary, and at the JSON benchmark artifacts (benchmark-results-rustvx, benchmark-results-khronos-sample, benchmark-comparison) attached to every workflow run. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.