chore: add some strict types#142
Open
GeoSot wants to merge 1 commit intokirschbaum-development:masterfrom
Open
chore: add some strict types#142GeoSot wants to merge 1 commit intokirschbaum-development:masterfrom
GeoSot wants to merge 1 commit intokirschbaum-development:masterfrom
Conversation
GeoSot
commented
Jul 7, 2023
GeoSot
commented
Jul 7, 2023
luisdalmolin
reviewed
Jul 7, 2023
luisdalmolin
reviewed
Jul 7, 2023
Member
luisdalmolin
left a comment
luisdalmolin
left a comment
There was a problem hiding this comment.
I like it, big types fan here. I just left one comment which I think needs to be addresses, and a question.
GeoSot
force-pushed
the
chore/add-strict-types
branch
from
6439d0d to
d9db74f
Compare
Member
|
@GeoSot Sorry for the long time to merge this, but if you want to fix the merge conflicts, we can merge this. |
GeoSot
force-pushed
the
chore/add-strict-types
branch
from
d9db74f to
ee5f6e0
Compare
Contributor
Author
|
It's fine @luisdalmolin. Later you may take a look on |
GeoSot
force-pushed
the
chore/add-strict-types
branch
from
ee5f6e0 to
deed185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just another one quality scoped PR. Adding some typed properties and return types, plus two deletions that are pointed below
@luisdalmolin is up to your decision, again