Fix latestOfMany relationships using wrong foreign key in subqueries#213
Merged
luisdalmolin merged 6 commits intomasterfrom Jul 10, 2025
Merged
Fix latestOfMany relationships using wrong foreign key in subqueries#213luisdalmolin merged 6 commits intomasterfrom
luisdalmolin merged 6 commits intomasterfrom
Conversation
When using leftJoinRelationship with latestOfMany relationships that have custom foreign keys, the generated subquery was incorrectly using the parent model's primary key instead of the relationship's local key. This caused wrong join conditions and incorrect query results. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
The previous fix was accessing $this->localKey inside nested closures where $this context was not available, causing "Call to a member function make() on null" errors in PostgreSQL tests. Fixed by extracting $this->localKey to a variable before passing it to the closures. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
• Fix latestOfMany relationships incorrectly using primary key instead of relationship's local key in subqueries when using custom foreign keys
• Add comprehensive test coverage for latestOfMany relationships with custom foreign keys
Test plan
🤖 Generated with opencode