Allow version-based id attribute#7
Open
thechrisnixon wants to merge 2 commits intokirtithorat:masterfrom
Open
Conversation
Allow setting the previewbox id selector with a version to customize pre...
Owner
|
@dasnixon Thank you for the suggestion. Apologies for my late reply. Could you please tell me your use-case of version-based id attribute? Is it like you show multiple preview boxes on the same page but for different versions? |
Author
|
Yes exactly. The screenshot below is how we currently use it. Thanks for looking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow for more customizable preview boxes for different versions of the photo you are cropping (e.g.
retina(500x500),standard(250x250))Let me know how this looks and I will update the
README.