Skip to content

Conversation

@Pfeil
Copy link
Member

@Pfeil Pfeil commented Sep 30, 2025

Plan: support updates of a whole graph, which may be a mix of new and existing records.

Some guidelines:

  • make API (body to sent) more explicit on what it will do
  • simplify code
  • For now, support only full overrides, as the typed pid maker is used to with the non-batch api. Consider if a parameter makes sense to control this somehow. Like "merge" or so.

Status

  • introduce a way to express that a record may be registered already -> PidNode stores a pseudo pid (or not). Now, the PID can fully express the existence (or the wish for a custom PID).
    • Probably we should check if a PID is really registered if a request provides one to avoid expensive rollbacks on errors.
  • Adjust createPIDs
  • Adjust tests

@Pfeil Pfeil self-assigned this Sep 30, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch updatable-pid-graph

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Pfeil Pfeil changed the title Updatable pid graph Support partial updates in batch API Oct 1, 2025
@Pfeil Pfeil force-pushed the updatable-pid-graph branch from 59bccd5 to a3e6112 Compare October 1, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants