remove pagination from keywords view

Author: jnptk

backend/src/kitconcept/keywordmanager/services/get.py

@@ -35,17 +35,12 @@ def reply(self):
                 )
             keywords.sort(key=sort_keys.get(sort_on), reverse=reverse)
 
-        batch = HypermediaBatch(self.request, keywords)
-        items = [{"name": name, "total": count} for name, count in batch]
-
-        keywords_data = {
-            "@id": batch.canonical_url,
-            "items": items,
-            "items_total": batch.items_total,
+        result = {
+            "@id": self.context.absolute_url(),
+            "items": [{"name": name, "total": count} for name, count in keywords],
+            "items_total": len(keywords),
         }
-        if batch.links:
-            keywords_data["batching"] = batch.links
-        return keywords_data
+        return result
 
 
 class KeywordIndexesGet(Service):

frontend/packages/volto-keywordmanager/src/actions/keywords.ts

@@ -5,22 +5,16 @@ import { DELETE_KEYWORDS } from 'volto-keywordmanager/constants/Keywords';
 export function getKeywords({
   index = null,
   groupKeywords = false,
-  batchSize = 25,
-  batchStart = 0,
   sortOn = null,
   sortOrder = null,
 }: {
   index?: string | null;
   groupKeywords?: boolean;
-  batchSize?: number;
-  batchStart?: number;
   sortOn?: string;
   sortOrder?: string;
 }) {
   let params = new URLSearchParams({
     grouped: String(groupKeywords),
-    b_size: String(batchSize),
-    b_start: String(batchStart),
   });
 
   if (index) params.append('idx', index);

frontend/packages/volto-keywordmanager/src/components/KeywordManager.tsx

@@ -69,10 +69,6 @@ const KeywordManager = (props) => {
   const selectionCount =
     selectedKeys === 'all' ? keywords.items?.length : selectedKeys?.size;
   const [keywordIndex, setKeywordIndex] = useState<string>('Subject');
-  // Pagination
-  const [currentPage, setCurrentPage] = useState<number>(0);
-  const [pageSize, setPageSize] = useState<number>(25);
-  const pageSizes = [25, 50, 100];
   // Sorting
   const [sortDescriptor, setSortDescriptor] = useState<SortDescriptor>();
   const sortOn = sortDescriptor?.column;
@@ -81,13 +77,11 @@ const KeywordManager = (props) => {
 
   const options = useMemo(
     () => ({
-      ...(pageSize !== 25 && { batchSize: pageSize }),
-      ...(currentPage !== 0 && { batchStart: currentPage }),
       ...(keywordIndex !== 'Subject' && { idx: keywordIndex }),
       ...(sortOrder && { sortOrder: sortOrder }),
       ...(sortOn && { sortOn: sortOn }),
     }),
-    [pageSize, currentPage, keywordIndex, sortOrder, sortOn],
+    [keywordIndex, sortOrder, sortOn],
   );
 
   useEffect(() => {
@@ -351,34 +345,6 @@ const KeywordManager = (props) => {
           )}
         </TableBody>
       </Table>
-      {keywords?.items_total > Math.min(...pageSizes) && (
-        <Pagination
-          current={currentPage}
-          total={Math.ceil(keywords?.items_total / pageSize)}
-          pageSize={pageSize}
-          pageSizes={pageSizes}
-          onChangePage={(e, { value }) => {
-            setCurrentPage(value);
-            dispatch(
-              getKeywords({
-                batchSize: pageSize,
-                batchStart: pageSize * value,
-                ...(keywordIndex !== 'Subject' && { index: keywordIndex }),
-              }),
-            );
-          }}
-          onChangePageSize={(e, { value }) => {
-            setPageSize(value);
-            dispatch(
-              getKeywords({
-                batchSize: value,
-                batchStart: currentPage,
-                ...(keywordIndex !== 'Subject' && { index: keywordIndex }),
-              }),
-            );
-          }}
-        />
-      )}
       {isClient &&
         createPortal(
           <Toolbar