Skip to content

Add Keywordmanager utility, services & controlpanel - #1

Merged
jnptk merged 111 commits into
mainfrom
keywordmanager
Jul 21, 2026
Merged

Add Keywordmanager utility, services & controlpanel #1
jnptk merged 111 commits into
mainfrom
keywordmanager

Conversation

@jnptk

@jnptk jnptk commented Mar 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@jnptk
jnptk requested a review from davisagli March 30, 2026 09:03

@davisagli davisagli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the REST services, but not the keywordmanager tool or the frontend yet.

@jnptk Is the keywordmanager tool mostly copied from Products.PloneKeywordManager, or are there specific things you changed that you'd like me to check?

Comment thread backend/src/kitconcept/keywordmanager/services/configure.zcml Outdated
Comment thread backend/src/kitconcept/keywordmanager/services/configure.zcml
Comment thread backend/src/kitconcept/keywordmanager/services/delete.py Outdated
Comment thread backend/src/kitconcept/keywordmanager/services/delete.py
Comment thread backend/src/kitconcept/keywordmanager/services/get.py Outdated
Comment thread backend/src/kitconcept/keywordmanager/services/update.py Outdated
Comment thread backend/src/kitconcept/keywordmanager/services/delete.py Outdated
Comment thread backend/src/kitconcept/keywordmanager/services/update.py Outdated

@davisagli davisagli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have functional tests for the API endpoints.

@jnptk
jnptk marked this pull request as ready for review July 20, 2026 13:36

@tisto tisto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README needs an overhaul. No "coming soon" mentions, screenshot and screencast is needed.

Comment thread README.md Outdated
Change, merge and delete keywords (subjects) in Plone 6.

## Quick Start 🏁
> [!WARNING]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention "kitconcept website" and "kitconcept intranet" before VLT here. Add links to both distributions.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this warning has nothing todo with either one of the distributions, it soley highlights that the styling that comes with this package does not work with plain volto (because we use *.scss which vlt loads automatically, plain volto doesn't)

Comment thread README.md Outdated
Comment thread README.md Outdated
```

To format and rewrite the code base, ensuring it adheres to quality standards, run the following shell command.
## Screenshots 🖼️

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot should go to the top of the README. This is mandatory. Also include a short screencast in the readme.

@jnptk
jnptk merged commit ceb4d05 into main Jul 21, 2026
4 checks passed
@jnptk
jnptk deleted the keywordmanager branch July 21, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants