Listing With Date - #177
Conversation
…ncept.intranet into event-listing-variation
iFlameing
left a comment
iFlameing
left a comment
There was a problem hiding this comment.
Please see the design in ticket. the dates are not up and down but horizontal.
…ncept.intranet into event-listing-variation
…ncept.intranet into event-listing-variation
| "nav_title": null, | ||
| "preview_caption_link": null, | ||
| "remoteUrl": "/features/content-types", | ||
| "remoteUrl": "http://nohost/Plone/features/content-types", |
There was a problem hiding this comment.
How this got added here , not sure but removed it
There was a problem hiding this comment.
It's possible it is a bug in plone.exportimport. We should check to see if it happens again with remoteUrl
There was a problem hiding this comment.
yes, it is a bug in plone.exportimport.
|
@Tishasoumya-02 I have pushed the fix for eslint. Now the lint error will be fixed. |
iFlameing
left a comment
iFlameing
left a comment
There was a problem hiding this comment.
LGTM! But we have to remove the example content from the pr.
cc @sneridagh
|
@iFlameing Why do we need to remove the example content? |
Because it doesn't go through correctly, each example content pr add the effective date changes as well as the metadata.json. So, for me, it always makes sense to create example content separately than your PR. In this way it will be conflict free and anyone can merge that pr quickly. |
|
@iFlameing That is true in general, but I don't see any conflict here since it was only updating existing pages (not adding new ones) and they are not the same pages that were changed in other recent PRs. So I don't think we have to remove it in this case. |
5 participants
Screen.Recording.2025-08-13.at.4.54.09.PM.mov