Conversation
Tishasoumya-02
marked this pull request as draft
August 25, 2025 14:17
Tishasoumya-02
changed the title
Member
|
@davisagli @sneridagh Ready for review and merge. I’ve also added the settings in the control panel. By default, it’s set to false, so it won’t be shown. I encountered one issue: when updating the control panel settings, the site endpoint data isn’t updating immediately — we’re getting stale data and need to reload the page to see the changes. |
davisagli
reviewed
Oct 23, 2025
davisagli
left a comment
davisagli
left a comment
Member
There was a problem hiding this comment.
Overall this looks good. But I have one doubt about the global setting.
Member
|
@iFlameing without going and delve into details. I have no clue what does the feature does, nor how to enable it or how it does work. We need documentation for this in the default docs. Please try to be thorough with it and cover all the use cases from the user and the admin point of view. |
Member
I added the docs. |
Member
|
@sneridagh @davisagli @danalvrz Please test it out for last time. I think everything is implemented now :) |
davisagli
approved these changes
Oct 30, 2025
davisagli
changed the title
fredvd
pushed a commit
that referenced
this pull request
Nov 3, 2025
* Rating * changelog * recheck imports * update * add comments to customized components * add comments * fix * add other engagement icons * fix * comment out calling apis and fix tests failing * fix lint * fix lint and rename component * rename stylesheet * comment out things which would not work without proper data * fix lint * fix: add aria-label to button * fix * initial commit * backend for likes and comment * Install plone.app.discussion * 90% done * minor fix * fix after review * backend german translation * add cypress test * update pnpm * add backend changelog * add upgreade steps and update backend test * minor fix * add enable_likes behaviour and polish code * polish css code * fix test and format * final polish code * Add upgrade step to install plone.app.discussion * refactor code based on review * fix cypress test * fix backend-test * fix format * fix format * fix ci and cypress test * fix the text of sharing content * minor typo * add docs and improve global settings for like * add documentation and changelog * rename changelog file * Fix the bug when navigating to different pages and saving pages * Hide enable_likes field if enable_content_rating registry setting is disabled * final fix * There's no reason to reindex votes, since there is no votes index * Rename docs page to Content Interactions * Use proper i18n mechanism for translating share email subject * Edit changelog * Enable content rating for new sites, disable for upgraded sites * Fix cypress test, ratings are enabled by default now --------- Co-authored-by: iFlameing <ialokkumarsingh0@gmail.com> Co-authored-by: David Glick <david@glicksoftware.com>
danalvrz
added a commit
that referenced
this pull request
Feb 20, 2026
* Support optional instance-local.yaml in the backed to override zope setting on a development install. * Added the prepublish script * Add Content Interactions (rating, discussion, sharing) (#185) * Rating * changelog * recheck imports * update * add comments to customized components * add comments * fix * add other engagement icons * fix * comment out calling apis and fix tests failing * fix lint * fix lint and rename component * rename stylesheet * comment out things which would not work without proper data * fix lint * fix: add aria-label to button * fix * initial commit * backend for likes and comment * Install plone.app.discussion * 90% done * minor fix * fix after review * backend german translation * add cypress test * update pnpm * add backend changelog * add upgreade steps and update backend test * minor fix * add enable_likes behaviour and polish code * polish css code * fix test and format * final polish code * Add upgrade step to install plone.app.discussion * refactor code based on review * fix cypress test * fix backend-test * fix format * fix format * fix ci and cypress test * fix the text of sharing content * minor typo * add docs and improve global settings for like * add documentation and changelog * rename changelog file * Fix the bug when navigating to different pages and saving pages * Hide enable_likes field if enable_content_rating registry setting is disabled * final fix * There's no reason to reindex votes, since there is no votes index * Rename docs page to Content Interactions * Use proper i18n mechanism for translating share email subject * Edit changelog * Enable content rating for new sites, disable for upgraded sites * Fix cypress test, ratings are enabled by default now --------- Co-authored-by: iFlameing <ialokkumarsingh0@gmail.com> Co-authored-by: David Glick <david@glicksoftware.com> * Update to Volto 19.29.0 and vlt 7.5.1 (#268) * Update to Volto 19.29.0 and vlt 7.5.1 * lock * Update Share email text (#273) * Move news fragment to right folder * Apply suggestion from @davisagli don't use instance-local.yml in the observed files list Co-authored-by: David Glick <david@glicksoftware.com> --------- Co-authored-by: Victor Fernandez de Alba <sneridagh@gmail.com> Co-authored-by: Tisha Soumya <tishasoumya@gmail.com> Co-authored-by: iFlameing <ialokkumarsingh0@gmail.com> Co-authored-by: David Glick <david@glicksoftware.com> Co-authored-by: Dante Álvarez <89805481+danalvrz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.