Additional solr updates by reekitconcept · Pull Request #189 · kitconcept/kitconcept.intranet

reekitconcept · 2025-08-27T11:58:21Z

update kitconcept.solr to 2.0.0-a2, 2.0.0-alpha.2
search result style changes
- hide builtin search input
- keep search term after being submitted
- make search result page full width
- highlight searchbox on hover and focus
necessary updates on solrSearchAutosuggest
- wire the search widget in the header
make search keep current state (ie. sorting by, etc.)

reekitconcept · 2025-08-27T15:10:52Z

UPDATE: what I write in the comment below is not needed any more.

To try this out, you manually have to switch kitconcept.solr to the additional-solr-updates branch, and make sure python installs this branch.

It is unknown if this can be done in a better way with uv. The way I did it is I checked out the branch somewhere, then manually added this to pyproject.yaml. Then build the backend with this. The path has to be the location where you checked out kitconcept.solr locally. I don't know any way how this could be checked in currently.

[project]
...
dependencies = [

   ...

    "kitconcept.solr @ /Users/ree/work/kitconcept/solr/kitconcept.solr/backend",
]

tisto · 2025-08-27T16:24:33Z

@reekitconcept I get an error when I run "make" after doing the amendments you specified:

kitconcept.intranet git:(additional-solr-updates) ✗ make
Install Backend & Frontend
==> Sync project dependencies
error: Failed to generate package metadata for `kitconcept-intranet @ editable+.`
  Caused by: The build backend returned an error
  Caused by: Call to `hatchling.build.prepare_metadata_for_build_editable` failed (exit status: 1)

[stderr]
Traceback (most recent call last):
  File "<string>", line 14, in <module>
  File "/Users/timo/.cache/uv/builds-v0/.tmpZBj31m/lib/python3.12/site-packages/hatchling/build.py", line 142, in prepare_metadata_for_build_editable
    f.write(builder.config.core_metadata_constructor(builder.metadata, extra_dependencies=extra_dependencies))
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/timo/.cache/uv/builds-v0/.tmpZBj31m/lib/python3.12/site-packages/hatchling/metadata/spec.py", line 574, in construct_metadata_file_2_4
    if metadata.core.dependencies:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/timo/.cache/uv/builds-v0/.tmpZBj31m/lib/python3.12/site-packages/hatchling/metadata/core.py", line 1220, in dependencies
    self._dependencies = list(self.dependencies_complex)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/timo/.cache/uv/builds-v0/.tmpZBj31m/lib/python3.12/site-packages/hatchling/metadata/core.py", line 1205, in dependencies_complex
    raise ValueError(message)
ValueError: Dependency #11 of field `project.dependencies` cannot be a direct reference unless field `tool.hatch.metadata.allow-direct-references` is set to `true`

hint: This usually indicates a problem with the package or the build environment.
make[2]: *** [sync] Error 2
make[1]: *** [backend-install] Error 2
make: *** [install] Error 2

I had to add this to pyproject.toml:

[tool.hatch.metadata]
allow-direct-references = true

reekitconcept · 2025-08-28T11:50:08Z

To try this out, you manually have to switch kitconcept.solr to the additional-solr-updates branch, and make sure python installs this branch.

It is unknown if this can be done in a better way with uv. The way I did it is I checked out the branch somewhere, then manually added this to pyproject.yaml. Then build the backend with this. The path has to be the location where you checked out kitconcept.solr locally. I don't know any way how this could be checked in currently.
[project]
...
dependencies = [

   ...

    "kitconcept.solr @ /Users/ree/work/kitconcept/solr/kitconcept.solr/backend",
]

Update, I found a way to do this from the config, so you don't need any of the above any more. It won't give you a checkout that you can develop locally though, so if you need local development on the dependent package (in this case kitconcept.solr) you still need to check it out manually and add the dependency override I described above. However for running the app locally or on servers, this isn't needed now.

reekitconcept · 2025-08-28T12:17:10Z

I had to add this to pyproject.toml:
[tool.hatch.metadata]
allow-direct-references = true

Sorry, I forgot to mention this.

On the bright side, I figured out how to do this without the need to any edit, and added that as a new commit. It also contains the hatch change.

- update kitconcept.solr to 2.0.0-a2, 2.0.0-alpha.2 - search result style changes - hide builtin search input - keep search term after being submitted - make search result page full width - highlight searchbox on hover and focus - necessary updates on solrSearchAutosuggest - wire the search widget in the header - make search keep current state (ie. sorting by, etc.) Also: - fix test that checks restapi version, now 9.15.2

tisto · 2025-09-19T20:42:10Z

@ericof can we merge this PR now or is anything holding us back?

ericof · 2025-09-19T21:29:59Z

Yes, we can.

tisto · 2025-09-19T22:11:20Z

  "dependencies": {
    "@kitconcept/core": "workspace:*",
-    "@kitconcept/volto-solr": "2.0.0-alpha.1",
+    "@kitconcept/volto-solr": "2.0.0-alpha.2",


@ericof this commit made all a11y tests fail. I have no clue why this happens.

@tisto This is the rule that is failing: "Ensures every ARIA input field has an accessible name (aria-input-field-name)"

I guess it is something wrong with the autocomplete livesearch input from kitconcept/kitconcept.solr#43 since that appears in the header of every page

@ericof this commit made all a11y tests fail. I have no clue why this happens.

This is the latest released version of @kitconcept/volto-solr. We need to fix the issue there :-(

@davisagli right. Good catch. The good thing is that it means we fetch the correct code and functionality. Then someone needs to look at how we can fix these a11y regressions.

kitconcept.intranet is passing an aria-label here:

https://github.com/kitconcept/kitconcept.intranet/pull/189/files#diff-f5cb42803c283b5e1d30960373e13f4973dcfa47f4c70f45876aee2deca38b21R168

but it is not used by the SolrSearchAutosuggestWidget in kitconcept-solr (https://github.com/kitconcept/kitconcept.solr/blob/main/frontend/packages/volto-solr/src/components/theme/SolrSearchWidget/SolrSearchWidget.jsx)

@tisto @ericof I fixed a conditional (4bb41fb) so that it won't try to use the autosuggest search widget when solr is not active. That should be enough to make the a11y tests pass. We still need to follow up in kitconcept.solr and fix the issue so that the aria-label is there when it is enabled. But at least this way we won't cause a regression for sites that aren't using solr.

I also added an issue: kitconcept/kitconcept.solr#47

Awesome! Thanks a lot, David!

sneridagh · 2025-09-22T07:28:06Z

@@ -1,4 +1,5 @@
-import type { ConfigType } from '@plone/registry';
+import './theme/custom.scss';


@reekitconcept ????

reekitconcept requested a review from a team as a code owner August 27, 2025 11:58

reekitconcept requested review from tisto and removed request for a team August 27, 2025 15:12

reekitconcept requested a review from a team as a code owner August 28, 2025 11:47

reekitconcept force-pushed the additional-solr-updates branch from 604ebd1 to f5c1f30 Compare September 5, 2025 13:24

reekitconcept changed the title ~~WIP Additional solr updates~~ Additional solr updates Sep 5, 2025

reekitconcept requested review from ericof and sneridagh September 5, 2025 14:47

reekitconcept force-pushed the additional-solr-updates branch from 459c7d8 to 815f594 Compare September 9, 2025 08:22

reekitconcept force-pushed the additional-solr-updates branch from 815f594 to 4f3715d Compare September 9, 2025 11:13

tisto and others added 9 commits September 15, 2025 14:39

Merge branch 'main' into additional-solr-updates

f54dd26

Merge branch 'main' into additional-solr-updates

bf9fc45

Check for plone.restapi 9.15.1

9a4ce87

Merge branch 'main' into additional-solr-updates

ee765a8

Add Solr startup scripts

899d935

Update changelog

1cb8390

Revert Solr setup creation by default

c8c1179

Remove breakpoint

b17774a

Solr: Enable use_tika by default

e58f70b

davisagli reviewed Sep 19, 2025

View reviewed changes

Comment thread frontend/packages/volto-intranet/package.json

davisagli approved these changes Sep 19, 2025

View reviewed changes

tisto approved these changes Sep 19, 2025

View reviewed changes

ericof approved these changes Sep 19, 2025

View reviewed changes

Merge branch 'main' into additional-solr-updates

9f51d89

tisto reviewed Sep 19, 2025

View reviewed changes

Fix conditional for when to use the autosuggest search widget

4bb41fb

tisto merged commit 0336fe3 into main Sep 20, 2025
25 checks passed

tisto deleted the additional-solr-updates branch September 20, 2025 06:38

sneridagh reviewed Sep 22, 2025

View reviewed changes

		@@ -1,4 +1,5 @@
		import type { ConfigType } from '@plone/registry';
		import './theme/custom.scss';

Uh oh!

Conversation

reekitconcept commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reekitconcept commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tisto commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reekitconcept commented Aug 28, 2025

Uh oh!

reekitconcept commented Aug 28, 2025

Uh oh!

Uh oh!

tisto commented Sep 19, 2025

Uh oh!

ericof commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davisagli Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davisagli Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

reekitconcept commented Aug 27, 2025 •

edited

Loading

reekitconcept commented Aug 27, 2025 •

edited

Loading

tisto commented Aug 27, 2025 •

edited

Loading

davisagli Sep 19, 2025 •

edited

Loading

davisagli Sep 19, 2025 •

edited

Loading