Use image-widget in preview_image_link - #205
Merged
Merged
Conversation
…ncept/kitconcept.intranet into image-widget-in-preview-image-link
Member
|
@Tishasoumya-02 yesterday I think we fixed all the tests in other PR, this is no longer needed, however, make a quick assessment that the new widget is working as expected. Thanks. |
…ncept/kitconcept.intranet into image-widget-in-preview-image-link
Contributor
Author
|
Will add the cypress test for preview_image_link and wrap this PR. Everything works fine in the widget |
sneridagh
approved these changes
Sep 5, 2025
davisagli
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/137
I updated the image-widget code , I noticed I was using an older version of image-widget from volto in customizations , I updated it but still the external url does not work. Will try to debug it again tomorrow and see if I can find anything
@sneridagh @iFlameing