Skip to content

add a check for succesfull content request on axe tests - #222

Merged
davisagli merged 3 commits into
mainfrom
axe-test-expect-200
Sep 8, 2025
Merged

add a check for succesfull content request on axe tests#222
davisagli merged 3 commits into
mainfrom
axe-test-expect-200

Conversation

@jackahl

@jackahl jackahl commented Sep 8, 2025

Copy link
Copy Markdown
Member

fixes #217

@jackahl
jackahl requested a review from a team as a code owner September 8, 2025 13:27
@iRohitSingh

Copy link
Copy Markdown
Member

@jackahl Checked locally worked fine :

Screenshot 2025-09-08 at 7 26 21 PM

@davisagli davisagli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's less important to have it for the initial load of the homepage than for when the page that is being tested is loaded, which I already added. But sure, no harm in adding it.

@davisagli
davisagli merged commit 809d46d into main Sep 8, 2025
13 checks passed
@davisagli
davisagli deleted the axe-test-expect-200 branch September 8, 2025 15:37
@jackahl

jackahl commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

It's less important to have it for the initial load of the homepage than for when the page that is being tested is loaded, which I already added. But sure, no harm in adding it.

@davisagli oh, right! Just noticed that I am not actually checking what I wanted after a second look. But as you said doesn't do harm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y axe tests should check if page actually loaded

3 participants