Create site in German by default - #224
Merged
Merged
Conversation
Member
Author
|
Oh dear, we have to either update the acceptance tests to use German text, or create a different image for the acceptance tests that uses English instead of German. Edit: I made the site get created in English for the acceptance tests, because it was less work to change, and because we have a lot of developers who don't speak German. |
tisto
approved these changes
Sep 9, 2025
sneridagh
approved these changes
Sep 9, 2025
sneridagh
left a comment
sneridagh
left a comment
Member
There was a problem hiding this comment.
@davisagli @tisto my 5c:
I am ok with this change, but in my opinion, the acceptance tests must be in english, which the PR already takes care of, and we should keep it this way. As David points out, the majority of the devs do not speak German, and generating tests with literals which you don't know the translation for, is a PITA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/144