Update Person schema - #230
Merged
Merged
Conversation
ericof
requested changes
Sep 11, 2025
| title="Intranet-specific Person fields" | ||
| description="Add the intranet-specific person fields" | ||
| provides=".person.IPersonBehavior" | ||
| for="collective.person.content.person.IPerson" |
Contributor
There was a problem hiding this comment.
Do we plan to use this behavior on anything other than a Person? If not, I do not see a reason to remove this.
Member
Author
There was a problem hiding this comment.
I removed it because there was a warning saying it doesn't do anything for a behavior that doesn't have a factory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/134
Marking as draft, we have to release the other packages and update them here first.