Skip to content

Fix A11y headlines Unique headings in grid text - #231

Merged
jackahl merged 4 commits into
mainfrom
grid-text-a11y
Sep 12, 2025
Merged

Fix A11y headlines Unique headings in grid text#231
jackahl merged 4 commits into
mainfrom
grid-text-a11y

Conversation

@iRohitSingh

Copy link
Copy Markdown
Member

No description provided.

@iRohitSingh
iRohitSingh requested review from a team as code owners September 11, 2025 11:50
}
],
"plone.rightcolumn": [
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iRohitSingh what is this for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why? plone export import changes the order everytime you run the make update-example-content. It will be on every pr.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this does not seem to be a change in order but an addition of some data for a portlet. Just wondering if this is intentionally. If not please just remove the change from the PR

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@jackahl jackahl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackahl

jackahl commented Sep 11, 2025

Copy link
Copy Markdown
Member

@iRohitSingh a11y cypress fails on the grid. I think you need to take another look

@jackahl
jackahl merged commit 2174bb6 into main Sep 12, 2025
43 of 44 checks passed
@jackahl
jackahl deleted the grid-text-a11y branch September 12, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants