Fix Comments delete button ui - #464
Closed
iRohitSingh wants to merge 5 commits into
Closed
Conversation
Member
|
@tisto please see screenshot, this is how we want the delete button of comment correct? |
Member
|
@iFlameing since when do we have a "hide reply" / "Antwort ausblenden" button? Please keep discussions about features in the GitLab ticket. Github PRs are to discuss technical details. If we spread discussions everywhere, we will lose track. |
Member
|
@iRohitSingh the avatar icons looks very weird, they should be round (not sure if we should re-use the documentByLine/mention component that @Tishasoumya-02 wrote). |
Contributor
|
I think volto's comment component is being used here , it has it's own avatar and metadata components |
Member
Member
|
Now we don't need this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Link : https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/work_items/544
ScreenShot: