Suggest: do not embed the @components expansion links - #116
Merged
Conversation
Follow-up to the include_items fix cherry-picked from #106, per David's review comment on that PR: the full serialization also merged in expandable_elements(), so every fully serialized suggestion carried the @components dict (breadcrumbs, navigation, actions...) that the suggest dropdown never follows. Pass include_expansion=False alongside include_items=False. This commit is kept separate from the cherry-pick so it can itself be cherry-picked onto main for the v2 release, ahead of the feature branch merge. (cherry picked from commit e9a2b1e)
davisagli
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #114, follow-up to #105 / #106.
Per @davisagli's review comment on #106 (#106 (review)): the full serialization in
serialize_brain()also merged inexpandable_elements(), so every fully serialized suggestion carried the@componentsdict (breadcrumbs, navigation, actions...) that the suggest dropdown never follows. Passinclude_expansion=Falsealongsideinclude_items=False.This is a cherry-pick of the second commit of #115 (the feature-ai-rag counterpart), mirrored separately so the fix makes the v2 release ahead of the feature branch merge.
Test:
test_full_serialization_omits_the_expansion_componentsadded to the serialize_brain suite.