Banner block schema and tailwind conflict fix - #24
Conversation
| default: 'layout', | ||
| filterActions: ['layout', 'full'], | ||
| actions: config.blocks.widths, | ||
| actions: [ |
There was a problem hiding this comment.
@Tishasoumya-02 Aren’t we going backward from a configurable approach to a hardcoded one?
There was a problem hiding this comment.
It was a quick fix at that moment, I created a PR in VLT kitconcept/volto-light-theme#910, applying the same fix as it is for separator and button block blocks.tsx and ButtonStylingSchema
There was a problem hiding this comment.
We can close this PR
There was a problem hiding this comment.
@Tishasoumya-02 no because standalone banner block will be broken. The correct fix is only one line change.
actions: config.blocks.widths.map((width) => width.name)
missing map which we fix in Volto and left here. please amend this and then we will merge this. I will check the VLT pr.
There was a problem hiding this comment.
This still breaks the acceptance test , screenshot below
There was a problem hiding this comment.
yes, i check the button block there we don't even pass this will talk with @sneridagh regarding this https://github.com/kitconcept/volto-button-block/blob/main/packages/volto-button-block/src/components/schema.js#L86
2 participants
No description provided.