Accessibility improvement - #26
Merged
Merged
Conversation
sneridagh
approved these changes
Oct 28, 2025
sneridagh
left a comment
sneridagh
left a comment
Member
There was a problem hiding this comment.
@tomschall sorry for the delay, I just saw it. In case that this happen again, just ping me on usual channels.
sneridagh
added a commit
that referenced
this pull request
Oct 28, 2025
sneridagh
added a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves accessibility by rendering a semantic
<a>tag instead of a<Button>when the component is linked (data.href). Buttons are meant for actions, while links indicate navigation. Using the correct HTML element helps assistive technologies (like screen readers) interpret the component properly and enhances keyboard navigation and semantics.In edit mode, the button is still wrapped in a ConditionalLink, as before. In view mode, a plain
<a>tag is rendered when a link is present, and a<Button>is used only if no link exists.