Skip to content

Show Link icon when hovering over Teaser grid block.#793

Merged
danalvrz merged 47 commits into
mainfrom
card-link
Jun 9, 2026
Merged

Show Link icon when hovering over Teaser grid block.#793
danalvrz merged 47 commits into
mainfrom
card-link

Conversation

@Tishasoumya-02

@Tishasoumya-02 Tishasoumya-02 commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

@Tishasoumya-02 Tishasoumya-02 marked this pull request as ready for review February 16, 2026 10:32
@iFlameing iFlameing changed the title Card Link Icon Show Link icon when hovering over Teaser grid block. Feb 17, 2026
@iFlameing

Copy link
Copy Markdown
Member

@Tishasoumya-02 I am missing the toast implementation. is it in another pr?

Screenshot

Showteaser

Comment thread frontend/packages/volto-light-theme/src/primitives/Card/Card.tsx Outdated
@Tishasoumya-02

Tishasoumya-02 commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@iFlameing Yes in intranet kitconcept/kitconcept.intranet#329

@Tishasoumya-02 Tishasoumya-02 requested a review from iFlameing June 1, 2026 07:05
@Tishasoumya-02

Tishasoumya-02 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

As per Dante's suggestion , for smaller viewports - specifically for teaser blocks the card-link-icon would be visible beside the image and not in the summary box, so to have similar feel and design

@Tishasoumya-02 Tishasoumya-02 requested a review from danalvrz June 1, 2026 14:06

@danalvrz danalvrz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works great, I left only one comment.

Comment thread frontend/packages/volto-light-theme/src/primitives/LinkIconButton.tsx Outdated

@danalvrz danalvrz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danalvrz danalvrz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Two minor comments before we merge, please take a look:

Comment thread frontend/packages/volto-light-theme/src/primitives/LinkIconButton.tsx Outdated
Comment thread frontend/packages/volto-light-theme/src/theme/card.scss Outdated
@Tishasoumya-02 Tishasoumya-02 requested a review from danalvrz June 9, 2026 09:39
@Tishasoumya-02

Copy link
Copy Markdown
Contributor Author

Update: completed with the changes suggested

@danalvrz danalvrz merged commit ad305dc into main Jun 9, 2026
31 checks passed
@danalvrz danalvrz deleted the card-link branch June 9, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants