Skip to content

The “Link Content Type URL” was not resolved correctly#892

Merged
sneridagh merged 6 commits into
mainfrom
link-navigation
Jun 15, 2026
Merged

The “Link Content Type URL” was not resolved correctly#892
sneridagh merged 6 commits into
mainfrom
link-navigation

Conversation

@iFlameing

@iFlameing iFlameing commented Jun 12, 2026

Copy link
Copy Markdown
Member

@sneridagh I really wanted to improve the link of Fat Menu to use UniversalLink instead of react-router-dom because our UniversalLink handle all the case.

@iFlameing iFlameing requested review from danalvrz and sneridagh June 12, 2026 13:41
@iFlameing iFlameing changed the title Fix Link content type URL(external) in navigation being appended to t… The “Link Content Type URL” was not resolved correctly Jun 12, 2026
@sneridagh

Copy link
Copy Markdown
Member

@iFlameing the tests are failing. Also the isActive method is ok? can you write a test for it, and edge cases, just in case? :)

@iFlameing

Copy link
Copy Markdown
Member Author

@iFlameing the tests are failing. Also the isActive method is ok? can you write a test for it, and edge cases, just in case? :)

I don't know why vrt test are failing, first time it fails on vertical spacing, second time on homepage. Let's see this time.
main is already merge. I added the unit test for isActive function.

@sneridagh sneridagh merged commit 1c71a18 into main Jun 15, 2026
31 checks passed
@sneridagh sneridagh deleted the link-navigation branch June 15, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants