Skip to content

fix(e2e): stabilize flaky layout-overflow-styling table width test#1500

Merged
kitelev merged 2 commits intomainfrom
fix/flaky-e2e-layout-overflow-test
Jan 7, 2026
Merged

fix(e2e): stabilize flaky layout-overflow-styling table width test#1500
kitelev merged 2 commits intomainfrom
fix/flaky-e2e-layout-overflow-test

Conversation

@kitelev
Copy link
Owner

@kitelev kitelev commented Jan 7, 2026

Summary

  • Stabilize flaky e2e test layout-overflow-styling.spec.ts:103 that checks table width constraints
  • Add proper layout stabilization waits before measuring table dimensions
  • Increase tolerance from 50px to 100px to account for CI environment rendering variations

Changes

  • Add 1000ms wait after waitForElement() for CSS layout to settle
  • Add double requestAnimationFrame wait before measuring each table
  • Increase tolerance from 50px to 100px for cross-environment reliability

Root Cause Analysis

The test was flaky because:

  1. Timing issue: The test measured table dimensions immediately after elements became visible, but CSS layout calculations may not be complete
  2. No layout stabilization: Unlike other e2e tests in the same codebase, this test didn't wait for layout to settle after element render
  3. Tight tolerance: 50px was too strict for CI environments with different rendering characteristics

Testing

  • Build passes ✅
  • TypeScript check passes ✅
  • Unit tests pass ✅
  • E2E validation through CI

Acceptance Criteria

  • Fix timing issue in the test
  • Add proper wait for layout stabilization
  • CI should pass consistently

Fixes #1493

- Add 1000ms wait after initial element render for CSS layout stabilization
- Add double requestAnimationFrame wait before measuring each table
- Increase tolerance from 50px to 100px to account for rendering variations

Fixes #1493
@kitelev kitelev enabled auto-merge (squash) January 7, 2026 05:29
@kitelev kitelev merged commit 75e1698 into main Jan 7, 2026
21 of 22 checks passed
@kitelev kitelev deleted the fix/flaky-e2e-layout-overflow-test branch January 7, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Stabilize flaky e2e test - layout-overflow-styling.spec.ts

1 participant