fix(e2e): stabilize flaky layout-overflow-styling table width test#1500
Merged
fix(e2e): stabilize flaky layout-overflow-styling table width test#1500
Conversation
- Add 1000ms wait after initial element render for CSS layout stabilization - Add double requestAnimationFrame wait before measuring each table - Increase tolerance from 50px to 100px to account for rendering variations Fixes #1493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layout-overflow-styling.spec.ts:103that checks table width constraintsChanges
waitForElement()for CSS layout to settlerequestAnimationFramewait before measuring each tableRoot Cause Analysis
The test was flaky because:
Testing
Acceptance Criteria
Fixes #1493