Skip to content

Allow custom section id in landing layout #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctrl-q wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow custom section id in landing layout #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions _layouts/landing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,17 @@
{%- for _section in page.data.sections -%}
{%- include snippets/get-nav-url.html path=_section.background_image.src -%}
{%- assign _url = __return -%}
{%- if _section.id -%}
{%- assign _section_id = _section.id -%}
{%- else -%}
{%- assign _section_id = "hero-" | append: forloop.index -%}
{%- endif -%}
{%- if _section.theme == 'light' -%}
<section class="hero hero--center hero--light" id="hero-{{ forloop.index }}"
<section class="hero hero--center hero--light" id="{{ _section_id }}"
{%- elsif _section.theme == 'dark' -%}
<section class="hero hero--center hero--dark" id="hero-{{ forloop.index }}"
<section class="hero hero--center hero--dark" id="{{ _section_id }}"
{%- else -%}
<section class="hero hero--center" id="hero-{{ forloop.index }}"
<section class="hero hero--center" id="{{ _section_id }}"
{%- endif -%}
{%- if _section.background_color -%}
style="background-image: url({{ _url }}); background-color: {{ _section.background_color }};">
Expand Down