Skip to content

Improve changelog sheet dismissal controls#177

Open
dillweed wants to merge 1 commit intokitlangton:mainfrom
dillweed:codex/changelog-close-controls
Open

Improve changelog sheet dismissal controls#177
dillweed wants to merge 1 commit intokitlangton:mainfrom
dillweed:codex/changelog-close-controls

Conversation

@dillweed
Copy link

@dillweed dillweed commented Feb 27, 2026

Adds a persistent top Close control to the changelog sheet while keeping the existing bottom Close button, so users can dismiss long changelog content without scrolling to the end.

Summary by CodeRabbit

  • Bug Fixes
    • Improved changelog view navigation by adding a persistent Close button at the top of the sheet, making it easier to dismiss while maintaining the existing bottom Close button.

Adds a persistent top Close action in the changelog sheet while keeping the existing bottom Close button, so users can exit long release notes without scrolling to the end.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

📝 Walkthrough

Walkthrough

Changes improve the changelog sheet dismissal by adding a persistent top Close button in the navigation bar while retaining the existing bottom Close button. The ChangelogView is wrapped in a NavigationStack, and the title is moved from explicit text to a navigationTitle modifier.

Changes

Cohort / File(s) Summary
Changelog Sheet Enhancement
Hex/Features/Settings/ChangelogView.swift, Hex/Features/Settings/AboutView.swift
Removed top "Changelog" title, added navigationTitle modifier, and introduced a toolbar-based Close button for persistent top dismissal. ChangelogView is now wrapped in NavigationStack within the sheet presentation.
Changelog Entry
.changeset/40f4ab66.md
Added patch-level changelog entry for "hex-app" documenting the improvement to changelog sheet dismissal with persistent top Close control.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A changelog now sits with buttons so neat,
Top and bottom, dismissal complete!
NavigationStack keeps the structure tight,
Close buttons await, both left and right! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding a persistent top Close control to improve changelog sheet dismissal, which aligns with the changeset modifications and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.changeset/40f4ab66.md (1)

5-5: Include the PR number in the changeset summary.

Per coding guidelines, changeset summaries should include the GitHub issue/PR number in the format (#177).

Suggested fix
-Improve changelog sheet dismissal by adding a persistent top Close control while keeping the bottom Close button
+Improve changelog sheet dismissal by adding a persistent top Close control while keeping the bottom Close button (`#177`)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/40f4ab66.md at line 5, Update the changeset summary string
"Improve changelog sheet dismissal by adding a persistent top Close control
while keeping the bottom Close button" to append the PR number in the required
format (e.g. add " (`#177`)") so the summary includes the GitHub PR reference;
edit the single-line summary in .changeset/40f4ab66.md to include the PR number
immediately following the text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.changeset/40f4ab66.md:
- Line 5: Update the changeset summary string "Improve changelog sheet dismissal
by adding a persistent top Close control while keeping the bottom Close button"
to append the PR number in the required format (e.g. add " (`#177`)") so the
summary includes the GitHub PR reference; edit the single-line summary in
.changeset/40f4ab66.md to include the PR number immediately following the text.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f29125d and 14e0ed9.

📒 Files selected for processing (3)
  • .changeset/40f4ab66.md
  • Hex/Features/Settings/AboutView.swift
  • Hex/Features/Settings/ChangelogView.swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant