Improve changelog sheet dismissal controls#177
Improve changelog sheet dismissal controls#177dillweed wants to merge 1 commit intokitlangton:mainfrom
Conversation
Adds a persistent top Close action in the changelog sheet while keeping the existing bottom Close button, so users can exit long release notes without scrolling to the end.
📝 WalkthroughWalkthroughChanges improve the changelog sheet dismissal by adding a persistent top Close button in the navigation bar while retaining the existing bottom Close button. The ChangelogView is wrapped in a NavigationStack, and the title is moved from explicit text to a navigationTitle modifier. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.changeset/40f4ab66.md (1)
5-5: Include the PR number in the changeset summary.Per coding guidelines, changeset summaries should include the GitHub issue/PR number in the format
(#177).Suggested fix
-Improve changelog sheet dismissal by adding a persistent top Close control while keeping the bottom Close button +Improve changelog sheet dismissal by adding a persistent top Close control while keeping the bottom Close button (`#177`)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.changeset/40f4ab66.md at line 5, Update the changeset summary string "Improve changelog sheet dismissal by adding a persistent top Close control while keeping the bottom Close button" to append the PR number in the required format (e.g. add " (`#177`)") so the summary includes the GitHub PR reference; edit the single-line summary in .changeset/40f4ab66.md to include the PR number immediately following the text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.changeset/40f4ab66.md:
- Line 5: Update the changeset summary string "Improve changelog sheet dismissal
by adding a persistent top Close control while keeping the bottom Close button"
to append the PR number in the required format (e.g. add " (`#177`)") so the
summary includes the GitHub PR reference; edit the single-line summary in
.changeset/40f4ab66.md to include the PR number immediately following the text.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/40f4ab66.mdHex/Features/Settings/AboutView.swiftHex/Features/Settings/ChangelogView.swift
Adds a persistent top Close control to the changelog sheet while keeping the existing bottom Close button, so users can dismiss long changelog content without scrolling to the end.
Summary by CodeRabbit