Skip to content

Fix Option key special characters leaking through on hotkey events #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LekcRg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Option key special characters leaking through on hotkey events #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Hex/Features/Transcription/TranscriptionFeature.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ private extension TranscriptionFeature {

case .stopRecording:
Task { await send(.hotKeyReleased) }
return false // or `true` if you want to intercept
return true // Intercept to prevent Option key from printing special characters

case .cancel:
Task { await send(.cancel) }
Expand All @@ -217,7 +217,7 @@ private extension TranscriptionFeature {
// If we detect repeated same chord, maybe intercept.
if let pressedKey = keyEvent.key,
pressedKey == hotKeyProcessor.hotkey.key,
keyEvent.modifiers == hotKeyProcessor.hotkey.modifiers
keyEvent.modifiers.matchesExactly(hotKeyProcessor.hotkey.modifiers)
{
return true
}
Expand Down