Add array with options per HotKey #41
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luksab Haha no need for the big "NO MERGING" just make this PR a draft :) https://github.blog/news-insights/product-news/introducing-draft-pull-requests/ |
luksab
changed the title
|
Thanks, it was pretty late yesterday and I didn't find the button haha. |
|
Hey @kitlangton why did you close this PR? I wanted to keep it open as a draft to collect ideas for how exactly to implement this fairly big change. |
|
yes @kitlangton please reopen |
|
I... don't know why I closed it? Haha. Accident! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #13 and #39 by reworking the settings to allow for multiple hotkeys with individual settings each.
Right now, I only changed the HexSettings and made HotKey Hashable. The UI doesn't even compile, but we have so start somewhere.
The things that are missing off the top of my head are:
Feedback is very welcome on all parts of the code and the planning. For example, I'm not happy with the name
hotKeyOptionsfor the array that holds the HotKeys with their options.