Skip to content

Conversation

@beatrycze-volk
Copy link
Collaborator

Changes:

  • send only one list of documents to the view
  • send to the view count for results and documents
  • force iteration over SOLR results to call getTitle() function placed in offsetGet() function

Depends on #1526

@beatrycze-volk beatrycze-volk self-assigned this Mar 26, 2025
@beatrycze-volk beatrycze-volk added the ☇ bug A non-security related bug. label Mar 26, 2025
There is no need to pass whole `documents` array if it is only used to call `count()` on it
This function reads titles for documents without titles
@sebastian-meyer sebastian-meyer merged commit aaf6b21 into kitodo:5.0.x Apr 22, 2025
7 checks passed
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (7962abf) to head (ce0e821).
Report is 1 commits behind head on 5.0.x.

Additional details and impacted files
@@      Coverage Diff      @@
##   5.0.x   #1557   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@beatrycze-volk beatrycze-volk deleted the fix-missing-title branch May 12, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☇ bug A non-security related bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants