Skip to content

Change tokenization for more coherent search #6764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BartChris wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change tokenization for more coherent search #6764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Kitodo-DataManagement/src/main/java/org/kitodo/data/database/beans/ProcessKeywords.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
public class ProcessKeywords {
private static final Logger logger = LogManager.getLogger(ProcessKeywords.class);

public static final int LENGTH_MIN_REASONABLE = 1;
public static final int LENGTH_MIN_DEFAULT = 3;

private static final String ANY_METADATA_MARKER = "mdWrap";
Expand Down Expand Up @@ -97,7 +96,7 @@ public ProcessKeywords(Process process) {

// keywords for project search in default search
String projectTitle = Objects.nonNull(process.getProject()) ? process.getProject().getTitle() : "";
this.projectKeywords = filterMinLength(initSimpleKeywords(projectTitle, true), LENGTH_MIN_REASONABLE);
this.projectKeywords = filterMinLength(initSimpleKeywords(projectTitle, true), LENGTH_MIN_DEFAULT);

// keywords for batch search + default search
this.batchKeywords = filterMinLength(initBatchKeywords(process.getBatches()), LENGTH_MIN_DEFAULT);
Expand Down
2 changes: 1 addition & 1 deletion Kitodo/src/main/java/org/kitodo/production/services/data/FilterField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Constants for known search field names in filters.
*/
enum FilterField {
SEARCH(null, null, null, null, null, null, "search", ProcessKeywords.LENGTH_MIN_REASONABLE),
SEARCH(null, null, null, null, null, null, "search", ProcessKeywords.LENGTH_MIN_DEFAULT),
PROCESS_ID(null, null, null, "id", "process.id", null, null, -1),
PARENT_PROCESS_ID(null, null, null, "parent.id", "process.parent.id", null, null, -1),
PROCESS_TITLE("title", "process.title", LikeSearch.NO, null, null, null, "searchTitle",
Expand Down