Optimize user list #6803

BartChris · 2025-12-08T19:46:02Z

This Pull Request tries to adress the slow loading user list by using optimized SQL queries to retrieve the information we need for the user list.
Some aspects of the PR have already been discussed here. #6802

One aspect is whether the SQL querie for loading tasks "in processing" is too restrictive as it only looks for tasks where the user is actually the processing user.

https://github.com/BartChris/kitodo-production/blob/96c5e8e32408acd42e414309e2f9810e45d13a59/Kitodo/src/main/java/org/kitodo/production/services/data/UserService.java#L660-L665

However, i think this was the case before with the old implementation:

kitodo-production/Kitodo/src/main/java/org/kitodo/production/services/data/UserService.java

Lines 470 to 475 in 96c5e8e

    
           public List<Task> getTasksInProgress(User user) { 
        
               return user.getProcessingTasks().stream() 
        
                       .filter( 
        
                           task -> task.getProcessingStatus().equals(TaskStatus.INWORK) && Objects.nonNull(task.getProcess())) 
        
                       .collect(Collectors.toList()); 
        
           }

which only retrieved tasks where the user is set as processing user , if i am not mistaken. I believe this behavior is correct, as this check is only relevant in the user list when determining whether a user has tasks in progress, for example when deciding if the user can be deleted.

The other question was why we call Primefaces from the LazyUsermodel (see: #4378 (comment)). We however also do that in the LazyBeanModel and the LazyProcessModel

kitodo-production/Kitodo/src/main/java/org/kitodo/production/model/LazyProcessModel.java

Line 146 in 53eec68

PrimeFaces.current().executeScript("PF('sticky-notifications').renderMessage("

kitodo-production/Kitodo/src/main/java/org/kitodo/production/model/LazyBeanModel.java

Line 131 in 53eec68

PrimeFaces.current().executeScript("PF('sticky-notifications').renderMessage("

I basically adapted the implementation from there, so this maybe deserves a seperate discussion.

solth

@BartChris thank you very much, this does seem to improve the performance of the user list siginicantly. As far as I could test the caches did not create any erroneous lists. I just have a few suggestions concerning the code.

solth · 2026-01-05T16:24:24Z

Kitodo/src/main/java/org/kitodo/production/forms/BaseForm.java

Some imports become unused and should be removed after the proposed changes:

org.kitodo.data.database.beans.Client

org.kitodo.data.database.beans.Project

org.kitodo.data.database.beans.Role

org.kitodo.production.services.data.ClientService

org.kitodo.production.services.data.RoleService

solth · 2026-01-05T16:27:04Z

Kitodo/src/main/java/org/kitodo/production/forms/UserForm.java

     */
    public void checkAndDelete() {
-        if (getTasksInProgress(userObject).isEmpty()) {
+        if (!hasTasksInProgress(userObject)) {


Perhaps this if...else condition check can be inverted to prevent the negation with ! and make it easier to read? Something like

if (hasTasksInProgress(userObject)) { PrimeFaces.current().ajax().update("usersTabView:confirmResetTasksDialog"); PrimeFaces.current().executeScript("PF('confirmResetTasksDialog').show();"); } else { deleteUser(userObject); }

solth · 2026-01-05T16:28:36Z

Kitodo/src/main/java/org/kitodo/production/forms/UserForm.java

+
+    public String getClientNames(User user) {
+        List<String> clients = getLazyUserModel().getClientsCache().get(user.getId());
+        return (Objects.isNull(clients)  || clients.isEmpty()) ? "" : String.join(", ", clients);


Suggested change

return (Objects.isNull(clients) || clients.isEmpty()) ? "" : String.join(", ", clients);

return (Objects.isNull(clients) || clients.isEmpty()) ? "" : String.join(", ", clients);

solth · 2026-01-05T16:29:36Z

Kitodo/src/main/java/org/kitodo/production/forms/UserForm.java

+        return (LazyUserModel) lazyBeanModel;
+    }
+
+    public String getRoleTitles(User user) {


Please add javadoc to public methods (applies to all new public methods below as well)

solth · 2026-01-05T16:33:04Z

Kitodo/src/test/java/org/kitodo/production/services/data/UserServiceIT.java

-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;


Please avoid wildcard imports and replace with single class imports

solth · 2026-01-05T16:36:33Z

Kitodo/src/main/java/org/kitodo/production/services/data/UserService.java

+        Map<String, Object> params = new HashMap<>();
+        params.put("ids", userIds);
+        List<Object[]> rows = dao.getProjectionByQuery(hql, params);
+        Map<Integer, List<String>> result = new HashMap<>();
+        for (Object[] row : rows) {
+            Integer userId = (Integer) row[0];
+            String title = (String) row[1];
+            result.computeIfAbsent(userId, k -> new ArrayList<>()).add(title);
+        }
+        return result;


This part to gather the query parameters and retrieve the result is duplicated in the individual load..ForUsers methods and could/should be moved to a separate private method to avoid code duplication.

solth · 2026-01-05T16:38:45Z

Kitodo/src/main/java/org/kitodo/production/model/LazyUserModel.java

+
+    @Override
+    @SuppressWarnings("unchecked")
+    public List<Object> load(int first, int pageSize,


Please add javadoc

solth · 2026-01-05T16:49:17Z

@thomaslow it would be great if you could take a look at this pull request, too, since it does touch on several aspects you refactored in #6770

thomaslow

I tested this PR and couldn't find any issues. Unfortunately, I do not have that many active users (7) in my test database, so I can at the moment only measure performance improvements in milliseconds (reduction from 150ms to 70ms).

Anyway, the approach of querying roles, clients and projects in batches is of course reasonable and should significantly improve performance. The implementation looks good. I generally agree with @solth's comments regarding some minor code style improvements (Javadocs of public methods, unused imports, etc.).

@solth I think it would be easier to merge these changes into #6770 than the other way around. So it would be good to merge this PR earlier than #6770.

BartChris force-pushed the optimize_user_list branch from 0d215f6 to 3c529c2 Compare December 8, 2025 20:07

henning-gerhardt mentioned this pull request Dec 9, 2025

Slowly displaying list of users #4378

Open

BartChris force-pushed the optimize_user_list branch 2 times, most recently from 0bdf2f6 to 4cc085b Compare December 9, 2025 13:57

BartChris mentioned this pull request Dec 9, 2025

[3.9] Optimize user list #6806

Open

thomaslow mentioned this pull request Dec 11, 2025

Refactor Bean Scopes: User, Role, Authority, Client, LdapGroup, LdapServer forms #6770

Open

BartChris force-pushed the optimize_user_list branch 2 times, most recently from 4c65034 to 4dea1c8 Compare December 18, 2025 09:27

Optimize user list

93e6f05

BartChris force-pushed the optimize_user_list branch 2 times, most recently from e581209 to 39de045 Compare December 18, 2025 09:49

Add tests

7571ec4

BartChris force-pushed the optimize_user_list branch from 39de045 to 7571ec4 Compare December 18, 2025 09:53

BartChris added 2 commits December 18, 2025 11:00

Default null handling

56f66b9

Refactor cache handling

96c5e8e

BartChris marked this pull request as ready for review December 18, 2025 10:29

BartChris mentioned this pull request Dec 18, 2025

Remove reliance on bidirectional association in task-user relation #6802

Draft

refactor: explicitly mark users without in-progress tasks as false

d21ce8f

BartChris marked this pull request as draft December 18, 2025 11:06

BartChris marked this pull request as ready for review December 18, 2025 11:09

BartChris mentioned this pull request Dec 23, 2025

Optimize Process list by batching #6831

Draft

solth requested a review from thomaslow January 5, 2026 16:20

solth requested changes Jan 5, 2026

View reviewed changes

thomaslow reviewed Jan 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Optimize user list #6803

Optimize user list #6803

Uh oh!

BartChris commented Dec 8, 2025 •

edited

Loading

Uh oh!

solth left a comment

Uh oh!

solth Jan 5, 2026

Uh oh!

solth Jan 5, 2026 •

edited

Loading

Uh oh!

solth Jan 5, 2026

Uh oh!

solth Jan 5, 2026

Uh oh!

solth Jan 5, 2026

Uh oh!

solth Jan 5, 2026

Uh oh!

solth Jan 5, 2026

Uh oh!

solth commented Jan 5, 2026

Uh oh!

thomaslow left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public List<Task> getTasksInProgress(User user) {
	return user.getProcessingTasks().stream()
	.filter(
	task -> task.getProcessingStatus().equals(TaskStatus.INWORK) && Objects.nonNull(task.getProcess()))
	.collect(Collectors.toList());
	}

	return (Objects.isNull(clients) \|\| clients.isEmpty()) ? "" : String.join(", ", clients);
	return (Objects.isNull(clients) \|\| clients.isEmpty()) ? "" : String.join(", ", clients);

Optimize user list #6803

Are you sure you want to change the base?

Optimize user list #6803

Uh oh!

Conversation

BartChris commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solth left a comment

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

solth Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

solth commented Jan 5, 2026

Uh oh!

thomaslow left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BartChris commented Dec 8, 2025 •

edited

Loading

solth Jan 5, 2026 •

edited

Loading