-
Notifications
You must be signed in to change notification settings - Fork 68
Refactor Bean Scopes: Project, Template, Workflow, Docket, Ruleset forms #6847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thomaslow
wants to merge
28
commits into
kitodo:main
Choose a base branch
from
thomaslow:refactor-bean-scopes-project-forms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor Bean Scopes: Project, Template, Workflow, Docket, Ruleset forms #6847
thomaslow
wants to merge
28
commits into
kitodo:main
from
thomaslow:refactor-bean-scopes-project-forms
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity and role form.
…embering row index of referred list view.
…n be restored after navigating back from an edit view.
…sts between reloads and when editing a user.
…ons in authority edit view and role list view.
…ocket, ruleset list and edit views.
…apping of deprecated "title.keyword" field used before HibernateSearch update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all forms on the "projects" page from
@SessionScopedto@ViewScoped. In addition, a few minor cleanup improvements are made.Related to issues:
Includes PR:
Updated forms:
ProjectFormTemplateFormWorkflowFormDocketFormRulesetFormChanges:
@SessionScopedto@ViewScopedtabIndex- the currently active tabsortField- the field that is used for sortingsortOrder- the order of sortingfirstRow- the first data row shown in the data table (corresponds to a page)filter- the active list filterreferrerListOptions- the list optionssortField,sortOrder,firstRowandfilterencoded in a single parameter such they can be restored when navigating back to the list after editing a single entityDue to the replacement of
ProjectForm.java,TemplateForm.java, ..., merging with the following PR needs to be done more carefully such that any improvements are not lost: