Fix security warnings about local information disclosure in temporary directories - #7216
Open
thomaslow wants to merge 2 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 4 instances of the CodeQL security warning "Local information disclosure in a temporary directory".
The problem is that the old Java API
File.createTempFiledoes not necessarily apply very restrictive permissions to these files such that other non-tomcat users may get access to them. Instead, it is now recommended to use the newer APIFiles.createTempFile(with an additionals). However, there is still no guarantee that files are assigned the most restrictive permissions available. The official documentation ofFiles.createTempFileonly states:We could also try to set specific permissions, but I couldn't find an OS-independent way to do this.
Testing these changes in my Ubuntu 26.04 docker container (my tomcat runs as root user inside the container) reveals the following access permissions, which seem reasonable to me.
For a temporary directory (created by the ImageManagement class):
For a temporary file within that directory:
Previously, the global
/tmpdirectory was used (which can be accessed by everyone), and files had the following permissions: