-
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
|
Hydrogen is repeating the songs like a lot, my suggestion is to increase the mix index until the music can't be found on the queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements an autoplay feature that automatically plays the next track from a YouTube mix when the playback queue is exhausted. Key changes include the addition of a new LoopMode variant "Autoplay" in both the player and command modules, new functions in PlayerManager for autoplay handling and YouTube ID resolution, and updates to i18n files and configurations to support the new feature.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hydrolink/src/cluster.rs | Added a getter for user_id. |
| hydrogen/src/music/player.rs | Updated LoopMode enum and track structure to include autoplay and YouTube identifiers. |
| hydrogen/src/music/mod.rs | Added new autoplay logic and helper functions to fetch YouTube tracks. |
| hydrogen/src/main.rs | Adjusted PlayerManager initialization to pass user id. |
| Various (i18n, commands, TODO, README, CHANGELOG) | Updated localization, command options, documentation, and changelog to integrate autoplay mode. |
Comments suppressed due to low confidence (1)
hydrogen/src/music/player.rs:928
- Consider adding parentheses to clarify operator precedence. If the intention is to compute ((player.current_track + 1) % player.queue.len()), the expression should be updated accordingly to ensure correct wrap-around behavior.
LoopMode::All => (player.current_track + 1 % player.queue.len(), false, true),
No description provided.