Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

Conversation

@kitsuvm
Copy link
Owner

@kitsuvm kitsuvm commented May 7, 2025

No description provided.

@kitsuvm kitsuvm self-assigned this May 7, 2025
@kitsuvm kitsuvm added the enhancement New feature or request label May 7, 2025
@kitsuvm
Copy link
Owner Author

kitsuvm commented May 7, 2025

Hydrogen is repeating the songs like a lot, my suggestion is to increase the mix index until the music can't be found on the queue.

@kitsuvm kitsuvm marked this pull request as draft May 7, 2025 18:21
@kitsuvm kitsuvm marked this pull request as ready for review June 11, 2025 21:40
@kitsuvm kitsuvm requested a review from Copilot June 11, 2025 21:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements an autoplay feature that automatically plays the next track from a YouTube mix when the playback queue is exhausted. Key changes include the addition of a new LoopMode variant "Autoplay" in both the player and command modules, new functions in PlayerManager for autoplay handling and YouTube ID resolution, and updates to i18n files and configurations to support the new feature.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hydrolink/src/cluster.rs Added a getter for user_id.
hydrogen/src/music/player.rs Updated LoopMode enum and track structure to include autoplay and YouTube identifiers.
hydrogen/src/music/mod.rs Added new autoplay logic and helper functions to fetch YouTube tracks.
hydrogen/src/main.rs Adjusted PlayerManager initialization to pass user id.
Various (i18n, commands, TODO, README, CHANGELOG) Updated localization, command options, documentation, and changelog to integrate autoplay mode.
Comments suppressed due to low confidence (1)

hydrogen/src/music/player.rs:928

  • Consider adding parentheses to clarify operator precedence. If the intention is to compute ((player.current_track + 1) % player.queue.len()), the expression should be updated accordingly to ensure correct wrap-around behavior.
LoopMode::All => (player.current_track + 1 % player.queue.len(), false, true),

@kitsuvm kitsuvm merged commit 51a1c63 into main Jun 11, 2025
1 check passed
@kitsuvm kitsuvm deleted the feat/autoplay-loop branch June 11, 2025 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants