Skip to content

failing test case for commonmark output with Escaped nodes.#680

Open
kivikakk wants to merge 1 commit intomainfrom
push-twkkwrlkytyu
Open

failing test case for commonmark output with Escaped nodes.#680
kivikakk wants to merge 1 commit intomainfrom
push-twkkwrlkytyu

Conversation

@kivikakk
Copy link
Copy Markdown
Owner

@kivikakk kivikakk commented Nov 2, 2025

In an input sequence like \™, with Escaped nodes left in (where a user asks for them to be), the CommonMark formatter can't see that & is followed by alpha (since the & is in an isolated node), so it doesn't think it needs escaping.

I've given this a few tries, but obvious solutions are not as easy as one would think.

@kivikakk kivikakk changed the base branch from main to push-pmyomryuyqnw November 2, 2025 06:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-1358bdf 106.5 ± 4.6 104.2 129.1 1.82 ± 0.08
./bench.sh ./comrak-main 105.3 ± 1.1 103.8 108.6 1.80 ± 0.03
./bench.sh ./pulldown-cmark 58.5 ± 0.8 57.6 60.9 1.00
./bench.sh ./cmark-gfm 90.2 ± 7.8 81.6 105.1 1.54 ± 0.14
./bench.sh ./markdown-it 255.1 ± 2.6 250.2 261.4 4.36 ± 0.08

Run on Sun Nov 2 06:55:06 UTC 2025

@kivikakk kivikakk force-pushed the push-twkkwrlkytyu branch 4 times, most recently from 578acfd to 99f360b Compare November 2, 2025 10:37
@kivikakk kivikakk changed the base branch from push-pmyomryuyqnw to push-wwkskvnvmwun November 2, 2025 10:41
Base automatically changed from push-wwkskvnvmwun to main November 3, 2025 03:52
@kivikakk kivikakk force-pushed the push-twkkwrlkytyu branch 3 times, most recently from c8ec7d3 to 37f0418 Compare November 9, 2025 06:23
@kivikakk kivikakk force-pushed the push-twkkwrlkytyu branch from 37f0418 to 5b53673 Compare March 10, 2026 10:45
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 10, 2026

Merging this PR will not alter performance

✅ 1 untouched benchmark


Comparing push-twkkwrlkytyu (5b53673) with main (a98aade)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant