Skip to content

Android sdkmanager proxy config #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuzeyron merged 6 commits into from
Nov 4, 2025
Merged

Android sdkmanager proxy config #1899

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab99b55
pass proxy config from env to sdkmanager to allow updating android sd…
sam-ti Mar 17, 2025
74ac6d1
Merge branch 'kivy:master' into feature/sdkmanager-proxy
broccoliboy Nov 4, 2025
adee127
look in both http and https env vars for proxy settings to pass throu…
broccoliboy Nov 4, 2025
2881608
fix tox errors
broccoliboy Nov 4, 2025
a7d25c3
remove if statement since try/except will handle proxy=None case
broccoliboy Nov 4, 2025
0efbb2d
consolidate
broccoliboy Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions buildozer/targets/android.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,12 @@ def _sdkmanager(self, *args, **kwargs):
android_sdk_dir = self.android_sdk_dir
kwargs['cwd'] = kwargs.get('cwd', android_sdk_dir)
command = [self.sdkmanager_path, f"--sdk_root={android_sdk_dir}", *args]

http_proxy = os.environ.get('HTTP_PROXY', os.environ.get('http_proxy'))
Copy link
Contributor

@kuzeyron kuzeyron Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS should be included with these checks.

Copy link
Contributor Author

@broccoliboy broccoliboy Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. I updated to look at http and https env vars. Please let me know if you have any other feedback.

if http_proxy:
host, port = http_proxy.split(':')[-2:]
host = host.strip('/')
command.extend(['--proxy=http', f'--proxy_host={host}', f'--proxy_port={port}'])

if kwargs.pop('return_child', False):
return buildops.cmd_expect(
Expand Down
Loading