MDTabsPrimary: Add remove_widget method to handle tab and carousel cleanup
#1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…abs`
Description of the problem
Removing a widget from the tab required insight into the internal working of MDTabsPrimary.
Description of Changes
Implemented remove_widget. This widget can receive an MDTabsItem as well as the related_content widget and will correctly remove the MDTabsItem and the related_content
Screenshots of the solution to the problem
Screencast_20251223_111512.webm
Code for testing new changes
An app for manual testing has been added into kivymd/tests/tab/add_remove_tab.py
I do realise this should ideally be a pytest, but do not have experience how to really automate gui testing.